Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pygmented AnnotationBear #2092

Open
userzimmermann opened this issue Oct 29, 2017 · 5 comments
Open

Pygmented AnnotationBear #2092

userzimmermann opened this issue Oct 29, 2017 · 5 comments

Comments

@userzimmermann
Copy link
Member

Instead of further complicating the AnnotationBear with #1332 it should first be simplified by using Pygments lexers instead of custom parsing for extraction of comment and string ranges from source code

This is also related to coala/coala#4775

@gitmate-bot
Copy link
Collaborator

GitMate.io thinks the contributor most likely able to help you is @jayvdb.

@userzimmermann
Copy link
Member Author

userzimmermann commented Oct 29, 2017

https://gist.github.com/userzimmermann/f43c4d1ae001ddc78bca5ce827bca8f1 shows my proof of concept for this

@aptrishu @Makman2 What do you think about it?

@Makman2
Copy link
Member

Makman2 commented Oct 29, 2017

That looks good, so in principle we use step-by-step pattern matching to assign to the parsed ast elements of pygments our SourceRange and other classes. I'm fine with that :)

@gitmate-bot
Copy link
Collaborator

This issue seems stale!

@userzimmermann please reassign yourself if you're still working on this.

(Powered by GitMate.io)

@bkhanale
Copy link
Member

This issue is reserved under the GSoC project Improve Generic Bear Quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants