Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function green_mode unnecessary delayed import of check_filename_prefix_postfix #300

Open
jayvdb opened this issue Aug 16, 2018 · 10 comments · May be fixed by #331
Open

function green_mode unnecessary delayed import of check_filename_prefix_postfix #300

jayvdb opened this issue Aug 16, 2018 · 10 comments · May be fixed by #331

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 16, 2018

coala_quickstart/green_mode/green_mode_core.py :: green_mode contains a delayed import of check_filename_prefix_postfix which should be removed as it shadows an identical import in the module scope.

@minhaj3
Copy link

minhaj3 commented Aug 19, 2018

Assign this issue to me

@rak-shit
Copy link

Is the issue solved? If no, I want to work on it.

@jayvdb
Copy link
Member Author

jayvdb commented Aug 29, 2018

@rak-shit It is assigned to @thenotsodarkknight . Read https://coala.io/newcomer to see how you should find suitable issues to work on

@fireballpoint1
Copy link

@thenotsodarkknight if you're not working on this can I ?

@Manas-kashyap
Copy link

can i work on it ?

@Ishaan29
Copy link

Ishaan29 commented Jan 3, 2019

hey! I would like to work on this issue , if it is still open .

@li-boxuan
Copy link
Member

Unassigned due to inactivity.

Ishaan29 added a commit to Ishaan29/coala-quickstart that referenced this issue Jan 6, 2019
Removed the delayed import of function check_filename_prefix_postfix
as it was already been called once , hence delayed import was
unnecessary

Closes coala#300
@Ishaan29 Ishaan29 linked a pull request Jan 6, 2019 that will close this issue
Ishaan29 added a commit to Ishaan29/coala-quickstart that referenced this issue Jan 7, 2019
Removed the delayed import of function check_filename_prefix_postfix
as it shadowed an identical import in module scope

Closes coala#300
Ishaan29 added a commit to Ishaan29/coala-quickstart that referenced this issue Jan 8, 2019
Removed the delayed import of function check_filename_prefix_postfix
as it shadowed an identical import in module scope

Closes coala#300
Ishaan29 added a commit to Ishaan29/coala-quickstart that referenced this issue Jan 8, 2019
Remove delayed import of function check_filename_prefix_postfix
as it shadowed an identical import in module scope

Closes coala#300
@pavanrkadave
Copy link

I want to work on this issue if its open!

@shashank-b
Copy link
Member

@pavanrkadave, someone is already working on this.

@pavanrkadave
Copy link

Ok

Ishaan29 added a commit to Ishaan29/coala-quickstart that referenced this issue Jan 9, 2019
This removes delayed import of function check_filename_prefix_postfix
as it shadowed an identical import in module scope

Closes coala#300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

10 participants