Skip to content

Commit 1d628f1

Browse files
update link + added test properties
1 parent 23ef524 commit 1d628f1

File tree

9 files changed

+9
-16
lines changed

9 files changed

+9
-16
lines changed

spring-kafka-batch-listener/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44

55
A detailed step-by-step tutorial on how to implement a Spring Kafka Batch Listener using Spring Boot.
66

7-
[https://www.codenotfound.com/2017/04/spring-kafka-batch-listener-example.html](https://www.codenotfound.com/2017/04/spring-kafka-batch-listener-example.html)
7+
[https://www.codenotfound.com/spring-kafka-batch-listener-example.html](https://www.codenotfound.com/spring-kafka-batch-listener-example.html)

spring-kafka-batch-listener/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<name>spring-kafka-batch-listener</name>
1111
<description>Spring Kafka - Batch Listener Example</description>
12-
<url>https://www.codenotfound.com/2017/04/spring-kafka-batch-listener-example.html</url>
12+
<url>https://www.codenotfound.com/spring-kafka-batch-listener-example.html</url>
1313

1414
<parent>
1515
<groupId>org.springframework.boot</groupId>

spring-kafka-batch-listener/src/main/java/com/codenotfound/kafka/consumer/Receiver.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,10 @@ public CountDownLatch getLatch() {
2121
return latch;
2222
}
2323

24-
@KafkaListener(id = "batch-listener", topics = "${topic.batch}")
24+
@KafkaListener(id = "batch-listener", topics = "${kafka.topic.batch}")
2525
public void receive(List<String> data,
2626
@Header(KafkaHeaders.RECEIVED_PARTITION_ID) List<Integer> partitions,
2727
@Header(KafkaHeaders.OFFSET) List<Long> offsets) {
28-
2928
LOGGER.info("start of batch receive");
3029
for (int i = 0; i < data.size(); i++) {
3130
LOGGER.info("received message='{}' with partition-offset='{}'", data.get(i),

spring-kafka-batch-listener/src/main/java/com/codenotfound/kafka/consumer/ReceiverConfig.java

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ public class ReceiverConfig {
2323
@Bean
2424
public Map<String, Object> consumerConfigs() {
2525
Map<String, Object> props = new HashMap<>();
26-
2726
props.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers);
2827
props.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class);
2928
props.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class);

spring-kafka-batch-listener/src/main/java/com/codenotfound/kafka/producer/SenderConfig.java

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ public class SenderConfig {
2121
@Bean
2222
public Map<String, Object> producerConfigs() {
2323
Map<String, Object> props = new HashMap<>();
24-
2524
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers);
2625
props.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, StringSerializer.class);
2726
props.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, StringSerializer.class);
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
kafka:
22
bootstrap-servers: localhost:9092
3-
4-
topic:
5-
batch: batch.t
3+
topic:
4+
batch: batch.t

spring-kafka-batch-listener/src/main/resources/logback.xml

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<logger name="com.codenotfound" level="INFO" />
1111
<logger name="org.springframework" level="WARN" />
1212

13-
1413
<root level="WARN">
1514
<appender-ref ref="STDOUT" />
1615
</root>

spring-kafka-batch-listener/src/test/java/com/codenotfound/kafka/SpringKafkaApplicationTest.java

-6
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.util.concurrent.TimeUnit;
66

77
import org.junit.Before;
8-
import org.junit.BeforeClass;
98
import org.junit.ClassRule;
109
import org.junit.Test;
1110
import org.junit.runner.RunWith;
@@ -38,11 +37,6 @@ public class SpringKafkaApplicationTest {
3837
@ClassRule
3938
public static KafkaEmbedded embeddedKafka = new KafkaEmbedded(1, true, BATCH_TOPIC);
4039

41-
@BeforeClass
42-
public static void setUpBeforeClass() {
43-
System.setProperty("kafka.bootstrap-servers", embeddedKafka.getBrokersAsString());
44-
}
45-
4640
@Before
4741
public void setUp() throws Exception {
4842
// wait until the partitions are assigned
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
kafka:
2+
bootstrap-servers: ${spring.embedded.kafka.brokers}
3+
topic:
4+
batch: batch.t

0 commit comments

Comments
 (0)