feat(schema-compiler): Yaml - duplicate check for view/cube names (cube-js#10400)

Author: ovr

packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts

@@ -96,11 +96,15 @@ export class YamlCompiler {
 
     for (const key of Object.keys(yamlObj)) {
       if (key === 'cubes') {
+        this.checkDuplicateNames(yamlObj.cubes || [], 'cube', errorsReport);
+
         (yamlObj.cubes || []).forEach(({ name, ...cube }) => {
           const transpiledCube = this.transpileAndPrepareJsFile('cube', { name, ...cube }, errorsReport);
           transpiledFilesContent.push(transpiledCube);
         });
       } else if (key === 'views') {
+        this.checkDuplicateNames(yamlObj.views || [], 'view', errorsReport);
+
         (yamlObj.views || []).forEach(({ name, ...cube }) => {
           const transpiledView = this.transpileAndPrepareJsFile('view', { name, ...cube }, errorsReport);
           transpiledFilesContent.push(transpiledView);
@@ -316,6 +320,22 @@ export class YamlCompiler {
     return body?.expression;
   }
 
+  private checkDuplicateNames(items: any[], type: 'cube' | 'view', errorsReport: ErrorReporter) {
+    const seen = new Set<string>();
+
+    for (const item of items) {
+      if (item?.name) {
+        if (seen.has(item.name)) {
+          errorsReport.error(
+            `Found duplicate ${type} name '${item.name}'.`
+          );
+        } else {
+          seen.add(item.name);
+        }
+      }
+    }
+  }
+
   private yamlArrayToObj(
     yamlArray,
     memberType: string,

packages/cubejs-schema-compiler/test/unit/yaml-schema.test.ts

@@ -146,6 +146,69 @@ cubes:
       }
     });
 
+    it('detects duplicate cube names', async () => {
+      const { compiler } = prepareYamlCompiler(`
+cubes:
+  - name: orders
+    sql_table: orders
+    dimensions:
+      - name: id
+        sql: id
+        type: number
+        primary_key: true
+
+  - name: orders
+    sql_table: orders_v2
+    dimensions:
+      - name: id
+        sql: id
+        type: number
+        primary_key: true
+      `);
+
+      try {
+        await compiler.compile();
+        throw new Error('compile must return an error');
+      } catch (e: any) {
+        expect(e.message).toContain("Found duplicate cube name 'orders'");
+      }
+    });
+
+    it('detects duplicate view names', async () => {
+      const { compiler } = prepareYamlCompiler(`
+cubes:
+  - name: orders
+    sql_table: orders
+    dimensions:
+      - name: id
+        sql: id
+        type: number
+        primary_key: true
+      - name: status
+        sql: status
+        type: string
+views:
+  - name: orders_view
+    cubes:
+      - join_path: orders
+        includes:
+          - id
+
+  - name: orders_view
+    cubes:
+      - join_path: orders
+        includes:
+          - status
+      `);
+
+      try {
+        await compiler.compile();
+        throw new Error('compile must return an error');
+      } catch (e: any) {
+        expect(e.message).toContain("Found duplicate view name 'orders_view'");
+      }
+    });
+
     it('detects duplicate dimension granularities', async () => {
       const { compiler } = prepareYamlCompiler(`
 cubes: