Skip to content

Commit 042b485

Browse files
fix(ci): fix npm audit vulnerabilities (firecrawl#2682)
- Update undici from ^7.10.0 to ^7.18.2 to fix GHSA-g9mf-h72j-4rw9 - Allowlist GHSA-73rr-hh4g-fpgx (jsdiff via ts-node and git-diff): Low severity DoS in patch parsing - affects dev tools only Co-authored-by: firecrawl-spring[bot] <254786068+firecrawl-spring[bot]@users.noreply.github.com> Co-authored-by: mogery <mogery@sideguide.dev>
1 parent 3a30784 commit 042b485

6 files changed

Lines changed: 30 additions & 38 deletions

File tree

apps/api/audit-ci.jsonc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
"GHSA-mh29-5h37-fv8m|@jest/globals>@jest/expect>jest-snapshot>@jest/transform>babel-plugin-istanbul>@istanbuljs/load-nyc-config>js-yaml", // not impacted by this
1010
"GHSA-36hm-qxxp-pg3m|@coinbase/x402>x402>wagmi>@wagmi/connectors>@coinbase/wallet-sdk>preact", // we don't use preact in our code paths
1111
"GHSA-3vhc-576x-3qv4|@coinbase/x402>x402>wagmi>@wagmi/connectors>porto>hono", // we don't use hono
12-
"GHSA-f67f-6cw9-8mq4|@coinbase/x402>x402>wagmi>@wagmi/connectors>porto>hono" // we don't use hono
12+
"GHSA-f67f-6cw9-8mq4|@coinbase/x402>x402>wagmi>@wagmi/connectors>porto>hono", // we don't use hono
13+
"GHSA-73rr-hh4g-fpgx|git-diff>diff", // dev dependency for diffs, not processing user-supplied patches
14+
"GHSA-73rr-hh4g-fpgx|ts-node>diff" // dev dependency for TypeScript execution, not processing user-supplied patches
1315
]
1416
}

apps/api/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133
"tldts": "^6.1.75",
134134
"tough-cookie": "^4.1.4",
135135
"turndown": "^7.1.3",
136-
"undici": "^7.10.0",
136+
"undici": "^7.18.2",
137137
"uuid": "^13.0.0",
138138
"winston": "^3.14.2",
139139
"ws": "^8.18.0",

apps/api/pnpm-lock.yaml

Lines changed: 13 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/api/src/scraper/scrapeURL/engines/utils/safeFetch.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import type { Socket } from "net";
22
import { config } from "../../../../config";
33
import type { TLSSocket } from "tls";
44
import * as undici from "undici";
5+
import { interceptors } from "undici";
56
import { CookieJar } from "tough-cookie";
67
import { cookie } from "http-cookie-agent/undici";
78
import IPAddr from "ipaddr.js";
@@ -19,11 +20,7 @@ export function isIPPrivate(address: string): boolean {
1920
}
2021

2122
function createBaseAgent(skipTlsVerification: boolean) {
22-
const agentOpts: undici.Agent.Options = {
23-
maxRedirections: 5000,
24-
};
25-
26-
return config.PROXY_SERVER
23+
const baseAgent = config.PROXY_SERVER
2724
? new undici.ProxyAgent({
2825
uri: config.PROXY_SERVER.includes("://")
2926
? config.PROXY_SERVER
@@ -34,14 +31,15 @@ function createBaseAgent(skipTlsVerification: boolean) {
3431
requestTls: {
3532
rejectUnauthorized: !skipTlsVerification, // Only bypass SSL verification if explicitly requested
3633
},
37-
...agentOpts,
3834
})
3935
: new undici.Agent({
4036
connect: {
4137
rejectUnauthorized: !skipTlsVerification, // Only bypass SSL verification if explicitly requested
4238
},
43-
...agentOpts,
4439
});
40+
41+
// Add redirect interceptor for handling redirects
42+
return baseAgent.compose(interceptors.redirect({ maxRedirections: 5000 }));
4543
}
4644

4745
function attachSecurityCheck(agent: undici.Dispatcher) {

apps/js-sdk/audit-ci.jsonc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
{
22
"$schema": "https://github.com/IBM/audit-ci/raw/main/docs/schema.json",
3-
"low": true
3+
"low": true,
4+
"allowlist": [
5+
"GHSA-73rr-hh4g-fpgx|ts-node>diff" // dev dependency for TypeScript execution, not processing user-supplied patches
6+
]
47
}
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
{
22
"$schema": "https://github.com/IBM/audit-ci/raw/main/docs/schema.json",
3-
"low": true
3+
"low": true,
4+
"allowlist": [
5+
"GHSA-73rr-hh4g-fpgx|ts-node>diff" // dev dependency for TypeScript execution, not processing user-supplied patches
6+
]
47
}

0 commit comments

Comments
 (0)