Added code to write to STDERR when no results found (#22)

* Added code to write to STDERR when no results found

* INTEG-935 added changelog

Author: kiran-chaudhary

CHANGELOG.md

@@ -8,10 +8,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 The intended audience of this file is for py42 consumers -- as such, changes that don't affect
 how a consumer would use the library (e.g. adding unit tests, updating documentation, etc) are not captured here.
 
+## 0.4.4 - 2020-04-01
+
+###Added
+
+- Added message to STDERR when no results are found
+
 ###Fixed
 
 - Add milliseconds to end timestamp, to represent end of day with milliseconds precision.
 
+## Unreleased
+
 ## 0.4.3 - 2020-03-17
 
 ### Added

src/code42cli/__version__.py

@@ -1 +1 @@
-__version__ = "0.4.3"
+__version__ = "0.4.4"

src/code42cli/securitydata/extraction.py

@@ -15,9 +15,10 @@
 from code42cli.securitydata.cursor_store import FileEventCursorStore
 from code42cli.securitydata.logger_factory import get_error_logger
 from code42cli.securitydata.options import ExposureType as ExposureTypeOptions
-from code42cli.util import print_error, print_bold, is_interactive
+from code42cli.util import print_error, print_bold, is_interactive, print_to_stderr
 
 _EXCEPTIONS_OCCURRED = False
+_TOTAL_EVENTS = 0
 
 
 def extract(output_logger, args):
@@ -142,6 +143,8 @@ def handle_error(exception):
     def handle_response(response):
         response_dict = json.loads(response.text)
         events = response_dict.get(u"fileEvents")
+        global _TOTAL_EVENTS
+        _TOTAL_EVENTS += len(events)
         for event in events:
             output_logger.info(event)
 
@@ -170,6 +173,9 @@ def _verify_compatibility_with_advanced_query(key, val):
 def _handle_result():
     if is_interactive() and _EXCEPTIONS_OCCURRED:
         print_error(u"View exceptions that occurred at [HOME]/.code42cli/log/code42_errors.")
+    global _TOTAL_EVENTS
+    if not _TOTAL_EVENTS:
+        print_to_stderr(u"No results found\n")
 
 
 def _try_append_exposure_types_filter(filters, args):

src/code42cli/util.py

@@ -70,3 +70,7 @@ def get_url_parts(url_str):
     if len(parts) > 1 and parts[1] != u"":
         port = int(parts[1])
     return parts[0], port
+
+
+def print_to_stderr(error_text):
+    sys.stderr.write(error_text)

tests/securitydata/test_extraction.py

@@ -511,3 +511,21 @@ def sdk_side_effect(self, *args):
 
     extraction_module.extract(logger, namespace_with_begin)
     assert extraction_module._EXCEPTIONS_OCCURRED
+
+
+def test_extract_when_no_results_are_found_prints_error_to_stderr(
+    mocker, logger, namespace_with_begin, extractor
+):
+    mock_error = mocker.patch("code42cli.securitydata.extraction.print_to_stderr")
+    extraction_module._TOTAL_EVENTS = 0
+    extraction_module.extract(logger, namespace_with_begin)
+    assert mock_error.call_count
+
+
+def test_extract_when_results_are_found_does_not_print_error_to_stderr(
+    mocker, logger, namespace_with_begin, extractor
+):
+    mock_error = mocker.patch("code42cli.securitydata.extraction.print_to_stderr")
+    extraction_module._TOTAL_EVENTS = 1
+    extraction_module.extract(logger, namespace_with_begin)
+    assert not mock_error.call_count