Skip to content

Commit 33e3d03

Browse files
authoredAug 19, 2021
Feature/new risk indicator (#315)
* added new risk-indicator filter values * adding new filter values * Update CHANGELOG.md
·
v1.19.0v1.9.0
1 parent 699d4cf commit 33e3d03

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed
 

‎CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ how a consumer would use the library (e.g. adding unit tests, updating documenta
2222

2323
- A TOTP token is now required on `code42 profile` commands that check for password validity when a user has MFA enabled.
2424

25+
- Updated minimum version of py42 to `1.18.0` to provide access to `FIRST_DESTINATION_USE` and `RARE_DESTINATION_USE` search filters.
26+
2527
### Fixed
2628

2729
- `code42 profile delete` command now prints a clear error message when deletion target doesn't exist.

‎setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"keyrings.alt==3.2.0",
4141
"ipython>=7.16.1",
4242
"pandas>=1.1.3",
43-
"py42>=1.17.0",
43+
"py42>=1.18.0",
4444
],
4545
extras_require={
4646
"dev": [

‎src/code42cli/cmds/securitydata.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
"PROTONMAIL": RiskIndicator.EmailServiceUploads.PROTONMAIL,
178178
"QQMAIL": RiskIndicator.EmailServiceUploads.QQMAIL,
179179
"SINA_MAIL": RiskIndicator.EmailServiceUploads.SINA_MAIL,
180-
"SOHU_MAIl": RiskIndicator.EmailServiceUploads.SOHU_MAIl,
180+
"SOHU_MAIL": RiskIndicator.EmailServiceUploads.SOHU_MAIL,
181181
"YAHOO": RiskIndicator.EmailServiceUploads.YAHOO,
182182
"ZOHO_MAIL": RiskIndicator.EmailServiceUploads.ZOHO_MAIL,
183183
"AIRDROP": RiskIndicator.ExternalDevices.AIRDROP,
@@ -207,6 +207,8 @@
207207
"FILE_MISMATCH": RiskIndicator.UserBehavior.FILE_MISMATCH,
208208
"OFF_HOURS": RiskIndicator.UserBehavior.OFF_HOURS,
209209
"REMOTE": RiskIndicator.UserBehavior.REMOTE,
210+
"FIRST_DESTINATION_USE": RiskIndicator.UserBehavior.FIRST_DESTINATION_USE,
211+
"RARE_DESTINATION_USE": RiskIndicator.UserBehavior.RARE_DESTINATION_USE,
210212
}
211213
risk_indicator_map_reversed = {v: k for k, v in risk_indicator_map.items()}
212214

‎tests/cmds/test_securitydata.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -854,7 +854,7 @@ def test_search_and_send_to_when_given_risk_indicator_uses_risk_indicator_filter
854854
("PROTONMAIL", RiskIndicator.EmailServiceUploads.PROTONMAIL),
855855
("QQMAIL", RiskIndicator.EmailServiceUploads.QQMAIL),
856856
("SINA_MAIL", RiskIndicator.EmailServiceUploads.SINA_MAIL),
857-
("SOHU_MAIl", RiskIndicator.EmailServiceUploads.SOHU_MAIl),
857+
("SOHU_MAIL", RiskIndicator.EmailServiceUploads.SOHU_MAIL),
858858
("YAHOO", RiskIndicator.EmailServiceUploads.YAHOO),
859859
("ZOHO_MAIL", RiskIndicator.EmailServiceUploads.ZOHO_MAIL),
860860
("AIRDROP", RiskIndicator.ExternalDevices.AIRDROP),
@@ -887,6 +887,8 @@ def test_search_and_send_to_when_given_risk_indicator_uses_risk_indicator_filter
887887
("FILE_MISMATCH", RiskIndicator.UserBehavior.FILE_MISMATCH),
888888
("OFF_HOURS", RiskIndicator.UserBehavior.OFF_HOURS),
889889
("REMOTE", RiskIndicator.UserBehavior.REMOTE),
890+
("FIRST_DESTINATION_USE", RiskIndicator.UserBehavior.FIRST_DESTINATION_USE),
891+
("RARE_DESTINATION_USE", RiskIndicator.UserBehavior.RARE_DESTINATION_USE),
890892
],
891893
)
892894
def test_all_caps_risk_indicator_choices_convert_to_risk_indicator_string(

0 commit comments

Comments
 (0)
Please sign in to comment.