Added controller spec & fixed intractors

Author: akhil-gautam

app/controllers/api/v1/users_controller.rb

@@ -18,11 +18,15 @@ def create
 
       def update
         authorize @user
-        # result = User::Update.call(params: user_params.except(:email))
+        if @user.update(user_params)
+          render json: { message: I18n.t('generic.update.success')}, status: :ok
+        else
+          render json: { errors: @user.error_string }, status: :unprocessable_entity
+        end
       end
 
       def login
-        user = User.find_by_email(login_params[:email])
+        user = User.verified.where(email: login_params[:email]).first
         if user&.authenticate(login_params[:password])
           token = JsonWebToken.encode(user_id: user.id)
           time = Time.zone.now + 100.hours
@@ -38,7 +42,7 @@ def login
 
       def verify
         user = User.find_by(reset_password_token: params[:token])
-        return render json: { error: I18n.t('user.errors.verify') }, status: :not_found unless user
+        return render json: { errors: I18n.t('user.errors.verify') }, status: :not_found unless user
 
         user.update(reset_password_token: nil)
         render json: { success: true }, status: :ok

app/controllers/application_controller.rb

@@ -21,7 +21,7 @@ def authenticate_user
         render json: { errors: 'Session expired. Please login again!' }, status: :unauthorized
       end
     else
-      render json: { errors: 'Authorization token not provided' }, status: :unauthorized
+      render json: { errors: 'Authentication token not provided' }, status: :unauthorized
     end
   end
 
@@ -36,6 +36,6 @@ def record_not_found
   end
 
   def unauthorized_access
-    return render json: { message: I18n.t('authorization.error') }, status: :forbidden
+    return render json: { errors: I18n.t('authorization.error') }, status: :forbidden
   end
 end

app/interactors/user/add_to_system.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
-module User
-  class AddToSystem
-    include Interactor::Organizer
+class User::AddToSystem
+  include Interactor::Organizer
 
-    organize User::Create, Mail::VerifyUser
-  end
+  organize User::Create, Mail::VerifyUser
 end

app/interactors/user/create.rb

@@ -1,20 +1,18 @@
 # frozen_string_literal: true
 
-module User
-  class Create
-    include Interactor
+class User::Create
+  include Interactor
 
-    def call
-      params = context.params.merge(
-        reset_password_token: SecureRandom.urlsafe_base64,
-        reset_password_sent_at: Time.now
-      )
-      user = User.new(params)
-      if user.save
-        context.user = user
-      else
-        context.fail!(error: user.error_string)
-      end
+  def call
+    params = context.params.merge(
+      reset_password_token: SecureRandom.urlsafe_base64,
+      reset_password_sent_at: Time.now
+    )
+    user = User.new(params)
+    if user.save
+      context.user = user
+    else
+      context.fail!(error: { errors: user.error_string })
     end
   end
 end

app/models/user.rb

@@ -31,6 +31,8 @@ class User < ApplicationRecord
   validates :email, presence: true, uniqueness: { case_sensitive: false }
   validates :password, length: { minimum: 8 }, on: :create
 
+  scope :verified, -> { where(reset_password_token: nil) }
+
   def full_name
     "#{first_name} #{last_name}"
   end

config/environments/production.rb

@@ -76,6 +76,8 @@
   # Use a different logger for distributed setups.
   # require "syslog/logger"
   # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new "app-name")
+  config.active_job.queue_adapter = :good_job
+  config.good_job.execution_mode = :external
 
   if ENV['RAILS_LOG_TO_STDOUT'].present?
     logger           = ActiveSupport::Logger.new($stdout)

config/environments/test.rb

@@ -29,6 +29,9 @@
   config.action_controller.perform_caching = false
   config.cache_store = :null_store
 
+  config.active_job.queue_adapter = :good_job
+  config.good_job.execution_mode = :inline
+  
   # Raise exceptions instead of rendering exception templates.
   config.action_dispatch.show_exceptions = false
 

config/locales/en.yml

@@ -6,5 +6,9 @@ en:
       not_found: User not found with the given ID.
   generic:
     record_not_found: Record not found.
+    create:
+      success: Created successfully.
+    update:
+      success: Updated successfully.
   authorization:
     error: Unauthorized access.

coverage/.last_run.json

@@ -1,5 +1,5 @@
 {
   "result": {
-    "line": 94.05
+    "line": 89.0
   }
 }