Skip to content

Pinned memory importance always 0.0 in recompute_importance formula #976

Description

@ajianaz

Problem

store.rs:315:

let importance = 0.3 * access_score + 0.3 * recency_score + 0.2 * connectivity + 0.2 * 0.0;

The pinned bonus term is hardcoded 0.2 * 0.0 instead of using m.pinned.

Fix

let pinned_score = if m.pinned { 1.0 } else { 0.0 };
let importance = 0.3 * access_score + 0.3 * recency_score + 0.2 * connectivity + 0.2 * pinned_score;

Severity: MAJOR (importance calc wrong for pinned memories)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingscope:coreCore engine work

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions