Merge pull request #2 from codefest-iit-bhu/ca-bug

Varun-Kolanu · web-flow · commit f601d7c9fd39 · 2024-12-03T00:07:17.000+05:30
fix: ca controller bug
diff --git a/controllers/ca.js b/controllers/ca.js
@@ -58,14 +58,14 @@ export const updateRequest = async (req, res, next) => {
       );
     }
     if (status) {
-      request.status = status;
       if (req.user.role === "admin" && status === "approved") {
         await User.findByIdAndUpdate(request.user, { role: "ca" });
       }
 
       if (req.user.role === "admin" && status !== "approved" && request.status === "approved") {
         await User.findByIdAndUpdate(request.user, { role: "user" });
       }
+      request.status = status;
     }
 
     if (req.user.role !== "admin") {

Original file line number	Diff line number	Diff line change
`@@ -58,14 +58,14 @@ export const updateRequest = async (req, res, next) => {`
`58`	`58`	`);`
`59`	`59`	`}`
`60`	`60`	`if (status) {`
`61`		`- request.status = status;`
`62`	`61`	`if (req.user.role === "admin" && status === "approved") {`
`63`	`62`	`await User.findByIdAndUpdate(request.user, { role: "ca" });`
`64`	`63`	`}`
`65`	`64`
`66`	`65`	`if (req.user.role === "admin" && status !== "approved" && request.status === "approved") {`
`67`	`66`	`await User.findByIdAndUpdate(request.user, { role: "user" });`
`68`	`67`	`}`
	`68`	`+ request.status = status;`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`if (req.user.role !== "admin") {`