Merge pull request #597 from kenjis/update-failed-tests-for-CI4.3.0

Update failed tests for CI4.3.0

Author: kenjis

psalm-baseline.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<files psalm-version="5.4.0@62db5d4f6a7ae0a20f7cc5a4952d730272fc0863">
+  <file src="src/Models/RememberModel.php">
+    <ReservedWord occurrences="1">
+      <code>$this-&gt;where(['user_id' =&gt; $user-&gt;id])-&gt;delete()</code>
+    </ReservedWord>
+  </file>
+  <file src="src/Models/UserIdentityModel.php">
+    <ReservedWord occurrences="1"/>
+  </file>
+  <file src="src/Controllers/MagicLinkController.php">
+    <ReservedWord occurrences="1"/>
+  </file>
+  <file src="src/Models/GroupModel.php">
+    <ReservedWord occurrences="1"/>
+  </file>
+</files>

psalm.xml

@@ -7,6 +7,7 @@
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
     autoloader="psalm_autoload.php"
     cacheDirectory="build/psalm/"
+    errorBaseline="psalm-baseline.xml"
 >
     <projectFiles>
         <directory name="src/" />

psalm_autoload.php

@@ -12,6 +12,10 @@
 
 foreach ($helperDirs as $dir) {
     $dir = __DIR__ . '/' . $dir;
+    if (! is_dir($dir)) {
+        continue;
+    }
+
     chdir($dir);
 
     foreach (glob('*_helper.php') as $filename) {
@@ -20,3 +24,5 @@
         require_once $filePath;
     }
 }
+
+chdir(__DIR__);

rector.php

@@ -114,9 +114,13 @@
         // Ignore tests that use CodeIgniter::CI_VERSION
         UnwrapFutureCompatibleIfPhpVersionRector::class => [
             __DIR__ . '/tests/Commands/UserModelGeneratorTest.php',
+            __DIR__ . '/tests/Controllers/LoginTest.php',
+            __DIR__ . '/tests/Commands/SetupTest.php',
         ],
         RemoveUnusedPrivatePropertyRector::class => [
             __DIR__ . '/tests/Commands/UserModelGeneratorTest.php',
+            __DIR__ . '/tests/Controllers/LoginTest.php',
+            __DIR__ . '/tests/Commands/SetupTest.php',
         ],
     ]);
     // auto import fully qualified class names

tests/Commands/SetupTest.php

@@ -4,6 +4,7 @@
 
 namespace Tests\Commands;
 
+use CodeIgniter\CodeIgniter;
 use CodeIgniter\Shield\Commands\Setup;
 use CodeIgniter\Test\Filters\CITestStreamFilter;
 use Config\Services;
@@ -21,15 +22,25 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        CITestStreamFilter::$buffer = '';
-        $this->streamFilter         = stream_filter_append(STDOUT, 'CITestStreamFilter');
+        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
+            CITestStreamFilter::registration();
+            CITestStreamFilter::addOutputFilter();
+        } else {
+            CITestStreamFilter::$buffer = '';
+            $this->streamFilter         = stream_filter_append(STDOUT, 'CITestStreamFilter');
+        }
     }
 
     protected function tearDown(): void
     {
         parent::tearDown();
 
-        stream_filter_remove($this->streamFilter);
+        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
+            CITestStreamFilter::removeOutputFilter();
+            CITestStreamFilter::removeErrorFilter();
+        } else {
+            stream_filter_remove($this->streamFilter);
+        }
     }
 
     public function testRun(): void

tests/Controllers/LoginTest.php

@@ -4,6 +4,7 @@
 
 namespace Tests\Controllers;
 
+use CodeIgniter\CodeIgniter;
 use CodeIgniter\Config\Factories;
 use CodeIgniter\I18n\Time;
 use CodeIgniter\Shield\Authentication\Actions\Email2FA;
@@ -64,7 +65,11 @@ public function testLoginBadEmail(): void
 
     public function testLoginActionEmailSuccess(): void
     {
-        Time::setTestNow('March 10, 2017', 'America/Chicago');
+        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
+            Time::setTestNow('March 10, 2017', 'UTC');
+        } else {
+            Time::setTestNow('March 10, 2017', 'America/Chicago');
+        }
 
         $this->user->createEmailIdentity([
             'email'    => '[email protected]',
@@ -116,7 +121,11 @@ public function testAfterLoggedInNotDisplayLoginPage(): void
 
     public function testLoginActionUsernameSuccess(): void
     {
-        Time::setTestNow('March 10, 2017', 'America/Chicago');
+        if (version_compare(CodeIgniter::CI_VERSION, '4.3.0', '>=')) {
+            Time::setTestNow('March 10, 2017', 'UTC');
+        } else {
+            Time::setTestNow('March 10, 2017', 'America/Chicago');
+        }
 
         // Add 'username' to $validFields
         $authConfig                = config('Auth');

tests/Unit/UserModelTest.php

@@ -173,7 +173,7 @@ public function testUpdateUserObjectWithUserDataToUpdate(): void
         $user->email    = '[email protected]';
         $user->active   = true;
 
-        $users->update(null, $user);
+        $users->update($user->id, $user);
 
         $this->seeInDatabase('auth_identities', [
             'user_id' => $user->id,
@@ -209,7 +209,7 @@ public function testUpdateUserArrayWithUserDataToUpdate(): void
         // Fix value type
         $userArray['active'] = (int) $userArray['active'];
 
-        $users->update(null, $userArray);
+        $users->update($user->id, $userArray);
 
         $this->dontSeeInDatabase('auth_identities', [
             'user_id' => $user->id,