Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit a27dcab

Browse files
authored
Enable trsm test on NVIDIA GPUs when using DEFAULT TUNING_TARGET (#518)
1 parent c6d3cad commit a27dcab

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ if (INSTALL_HEADER_ONLY)
169169
(${TUNING_TARGET} STREQUAL "INTEL_GPU") )
170170
target_compile_options(portblas INTERFACE -fno-fast-math)
171171
target_compile_options(portblas INTERFACE -mllvm=-loopopt=0)
172+
target_link_options(portblas INTERFACE -mllvm=-loopopt=0)
172173
message(STATUS "Adding -fno-fast-math -mllvm=-loopopt=0 to portblas")
173174
endif()
174175
else()

cmake/Modules/FindDPCPP.cmake

+1
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ function(add_sycl_to_target)
102102
(${TUNING_TARGET} STREQUAL "INTEL_GPU") )
103103
target_compile_options(${SB_ADD_SYCL_TARGET} PRIVATE -fno-fast-math)
104104
target_compile_options(${SB_ADD_SYCL_TARGET} PRIVATE -mllvm=-loopopt=0)
105+
target_link_options(${SB_ADD_SYCL_TARGET} PRIVATE -mllvm=-loopopt=0)
105106
message(STATUS "Adding -fno-fast-math -mllvm=-loopopt=0 to target ${SB_ADD_SYCL_TARGET}")
106107
endif()
107108
if ((${CMAKE_CXX_COMPILER_ID} STREQUAL "IntelLLVM"

src/operations/blas3/gemm_no_local_full_vec.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ class Gemm<input_t, output_t, DoubleBuffer, NbcA, NbcB, ClSize, tile_type,
381381
auto C = orig_C;
382382

383383
/* register array used to store the result*/
384-
value_t reg_res[item_rows * item_cols];
384+
element_t reg_res[item_rows * item_cols];
385385
scaling_c<need_check_boundary, packet_size>(
386386
reg_res, C, ldc, dim_m_a_start, dim_n_b_start, boundary_check_c,
387387
out_of_range);

test/unittest/CMakeLists.txt

-10
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,6 @@ if(is_dpcpp)
103103
)
104104
endif()
105105

106-
if(is_dpcpp AND ${TUNING_TARGET} STREQUAL "DEFAULT")
107-
if (${DPCPP_SYCL_TARGET} MATCHES "nvidia")
108-
set(TESTS_TO_SKIP
109-
${PORTBLAS_UNITTEST}/blas3/blas3_trsm_test.cpp
110-
)
111-
message(WARNING "Targetting NVIDIA hardware with DEFAULT TUNING_TARGET.
112-
Disabling tests for following operator: trsm.")
113-
endif()
114-
endif()
115-
116106
if(GEMM_TALL_SKINNY_SUPPORT)
117107
list(APPEND SYCL_UNITTEST_SRCS ${PORTBLAS_UNITTEST}/blas3/blas3_gemm_tall_skinny_test.cpp)
118108
endif()

0 commit comments

Comments
 (0)