Skip to content

Minor suggested updates to askmyfiles.py #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor suggested updates to askmyfiles.py #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c6945
Minor suggested updates to askmyfiles.py
stucarney Jul 11, 2023
5401791
Merge branch 'main' into patch-1
stucarney Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions askmyfiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def process_query_result(self, documents):

def query_db(self, string ):
max_results = 50

self.load_db()
query_embedding = self.embeddings_model.embed_query(string)
result = self.files_collection.query(query_embeddings=[query_embedding],n_results=max_results,include=['documents','metadatas'])
Expand Down Expand Up @@ -275,7 +276,6 @@ def add_webpage(self, url):

print(f"Creating embeddings...",end='',flush=True)
chunks = self.split_text(content)
chunk_count = len(chunks)
print(f"[{len(chunks)} chunks]",end='',flush=True)
vectorized_chunks = self.vectorize_chunks(chunks, metadata)
self.files_collection.delete(where={"file_hash": metadata["file_hash"]})
Expand Down Expand Up @@ -371,8 +371,9 @@ def ask(self, query):
[
Start with and prioritize knowledge from My askmyfiles Library when you answer my question.
Answer in a very detailed manner when possible.
If the question is regarding code: prefer to answer using service objects and other abstractions already defined in MyAskmyfilesLibrary and follow similar coding conventions.
If the question is regarding code: identify if there is a tags file present to inform your answers about modules, classes, and methods.
If the question is regarding code:
1. Try to answer using service objects and other abstractions already defined in MyAskmyfilesLibrary and follow similar coding conventions.
2. Identify if there is a tags file present to inform your answer about modules, classes, and methods.
]

### Question: {text}
Expand All @@ -391,6 +392,11 @@ def ask(self, query):
if index != -1:
sources = text[index + len("Sources:"):]

second_pass_query_db = f"""
{query}
{first_answer}
"""

second_pass_query = f"""
[
Consider the following first question and answer:
Expand All @@ -403,7 +409,7 @@ def ask(self, query):
"""

print("THINKING MORE...", end='', flush=True)
local_query_result2 = self.query_db(second_pass_query)
local_query_result2 = self.query_db(second_pass_query_db)
second_answer = answer_chain.run(excerpts=local_query_result2[1],hints=self.get_hints(),text=second_pass_query)

# Output
Expand Down