Skip to content

Commit 85ee441

Browse files
chore: bump typescript from 5.6.2 to 5.8.3 (#7335)
* chore: bump typescript from 5.6.2 to 5.8.3 Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.6.2 to 5.8.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release-publish.yml) - [Commits](microsoft/TypeScript@v5.6.2...v5.8.3) --- updated-dependencies: - dependency-name: typescript dependency-version: 5.8.3 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * as T * Update JSON error --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Asher <[email protected]>
1 parent a56769b commit 85ee441

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/node/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class SettingsProvider<T> {
1717
public async read(): Promise<T> {
1818
try {
1919
const raw = (await fs.readFile(this.settingsPath, "utf8")).trim()
20-
return raw ? JSON.parse(raw) : {}
20+
return raw ? JSON.parse(raw) : ({} as T)
2121
} catch (error: any) {
2222
if (error.code !== "ENOENT") {
2323
logger.warn(error.message)

test/unit/node/settings.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe("settings", () => {
2929
const settings = new SettingsProvider<CoderSettings>(pathToMockSettingsFile)
3030
await settings.read()
3131
// This happens when we can't parse a JSON (usually error in file)
32-
expect(logger.warn).toHaveBeenCalledWith(expect.stringMatching(/Unexpected token/))
32+
expect(logger.warn).toHaveBeenCalledWith(expect.stringMatching(/Expected ':'/))
3333
})
3434
})
3535
describe("with invalid settings file path", () => {

0 commit comments

Comments
 (0)