Revert "fix: opt-in tailscale vpn loop prevention (#148)"

This reverts commit 814b412.

Author: deansheather

App/App.xaml.cs

@@ -92,7 +92,6 @@ public App()
 
         services.AddSingleton<IDispatcherQueueManager>(_ => this);
         services.AddSingleton<IDefaultNotificationHandler>(_ => this);
-        services.AddSingleton<ISettingsManager<CoderConnectSettings>, SettingsManager<CoderConnectSettings>>();
         services.AddSingleton<ICredentialBackend>(_ =>
             new WindowsCredentialBackend(WindowsCredentialBackend.CoderCredentialsTargetName));
         services.AddSingleton<ICredentialManager, CredentialManager>();
@@ -121,6 +120,7 @@ public App()
         // FileSyncListMainPage is created by FileSyncListWindow.
         services.AddTransient<FileSyncListWindow>();
 
+        services.AddSingleton<ISettingsManager<CoderConnectSettings>, SettingsManager<CoderConnectSettings>>();
         services.AddSingleton<IStartupManager, StartupManager>();
         // SettingsWindow views and view models
         services.AddTransient<SettingsViewModel>();

App/Models/Settings.cs

@@ -34,11 +34,6 @@ public class CoderConnectSettings : ISettings<CoderConnectSettings>
     /// </summary>
     public bool ConnectOnLaunch { get; set; }
 
-    /// <summary>
-    /// When this is true Coder Connect will not attempt to protect against Tailscale loopback issues.
-    /// </summary>
-    public bool EnableCorporateVpnSupport { get; set; }
-
     /// <summary>
     /// CoderConnect current settings version. Increment this when the settings schema changes.
     /// In future iterations we will be able to handle migrations when the user has
@@ -51,21 +46,17 @@ public CoderConnectSettings()
         Version = VERSION;
 
         ConnectOnLaunch = false;
-
-        EnableCorporateVpnSupport = false;
     }
 
-    public CoderConnectSettings(int? version, bool connectOnLaunch, bool enableCorporateVpnSupport)
+    public CoderConnectSettings(int? version, bool connectOnLaunch)
     {
         Version = version ?? VERSION;
 
         ConnectOnLaunch = connectOnLaunch;
-
-        EnableCorporateVpnSupport = enableCorporateVpnSupport;
     }
 
     public CoderConnectSettings Clone()
     {
-        return new CoderConnectSettings(Version, ConnectOnLaunch, EnableCorporateVpnSupport);
+        return new CoderConnectSettings(Version, ConnectOnLaunch);
     }
 }

App/Services/CredentialManager.cs

@@ -223,9 +223,8 @@ private async Task<CredentialModel> LoadCredentialsInner(CancellationToken ct)
             };
         }
 
-        // Grab the lock again so we can update the state. Don't use the CT
-        // here as it may have already been canceled.
-        using (await _opLock.LockAsync(TimeSpan.FromSeconds(5), CancellationToken.None))
+        // Grab the lock again so we can update the state.
+        using (await _opLock.LockAsync(ct))
         {
             // Prevent new LoadCredentials calls from returning this task.
             if (_loadCts != null)
@@ -243,8 +242,11 @@ private async Task<CredentialModel> LoadCredentialsInner(CancellationToken ct)
                 if (latestCreds is not null) return latestCreds;
             }
 
-            UpdateState(model);
+            // If there aren't any latest credentials after a cancellation, we
+            // most likely timed out and should throw.
             ct.ThrowIfCancellationRequested();
+
+            UpdateState(model);
             return model;
         }
     }

App/Services/RpcController.cs

@@ -69,18 +69,16 @@ public interface IRpcController : IAsyncDisposable
 public class RpcController : IRpcController
 {
     private readonly ICredentialManager _credentialManager;
-    private readonly ISettingsManager<CoderConnectSettings> _settingsManager;
 
     private readonly RaiiSemaphoreSlim _operationLock = new(1, 1);
     private Speaker<ClientMessage, ServiceMessage>? _speaker;
 
     private readonly RaiiSemaphoreSlim _stateLock = new(1, 1);
     private readonly RpcModel _state = new();
 
-    public RpcController(ICredentialManager credentialManager, ISettingsManager<CoderConnectSettings> settingsManager)
+    public RpcController(ICredentialManager credentialManager)
     {
         _credentialManager = credentialManager;
-        _settingsManager = settingsManager;
     }
 
     public event EventHandler<RpcModel>? StateChanged;
@@ -158,7 +156,6 @@ public async Task StartVpn(CancellationToken ct = default)
         using var _ = await AcquireOperationLockNowAsync();
         AssertRpcConnected();
 
-        var coderConnectSettings = await _settingsManager.Read(ct);
         var credentials = _credentialManager.GetCachedCredentials();
         if (credentials.State != CredentialState.Valid)
             throw new RpcOperationException(
@@ -178,7 +175,6 @@ public async Task StartVpn(CancellationToken ct = default)
                 {
                     CoderUrl = credentials.CoderUrl?.ToString(),
                     ApiToken = credentials.ApiToken,
-                    TunnelUseSoftNetIsolation = coderConnectSettings.EnableCorporateVpnSupport,
                 },
             }, ct);
         }

App/ViewModels/SettingsViewModel.cs

@@ -13,9 +13,6 @@ public partial class SettingsViewModel : ObservableObject
     [ObservableProperty]
     public partial bool ConnectOnLaunch { get; set; }
 
-    [ObservableProperty]
-    public partial bool DisableTailscaleLoopProtection { get; set; }
-
     [ObservableProperty]
     public partial bool StartOnLoginDisabled { get; set; }
 
@@ -34,7 +31,6 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager<Cod
         _connectSettings = settingsManager.Read().GetAwaiter().GetResult();
         StartOnLogin = startupManager.IsEnabled();
         ConnectOnLaunch = _connectSettings.ConnectOnLaunch;
-        DisableTailscaleLoopProtection = _connectSettings.EnableCorporateVpnSupport;
 
         // Various policies can disable the "Start on login" option.
         // We disable the option in the UI if the policy is set.
@@ -47,21 +43,6 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager<Cod
         }
     }
 
-    partial void OnDisableTailscaleLoopProtectionChanged(bool oldValue, bool newValue)
-    {
-        if (oldValue == newValue)
-            return;
-        try
-        {
-            _connectSettings.EnableCorporateVpnSupport = DisableTailscaleLoopProtection;
-            _connectSettingsManager.Write(_connectSettings);
-        }
-        catch (Exception ex)
-        {
-            _logger.LogError($"Error saving Coder Connect {nameof(DisableTailscaleLoopProtection)} settings: {ex.Message}");
-        }
-    }
-
     partial void OnConnectOnLaunchChanged(bool oldValue, bool newValue)
     {
         if (oldValue == newValue)
@@ -73,7 +54,7 @@ partial void OnConnectOnLaunchChanged(bool oldValue, bool newValue)
         }
         catch (Exception ex)
         {
-            _logger.LogError($"Error saving Coder Connect {nameof(ConnectOnLaunch)} settings: {ex.Message}");
+            _logger.LogError($"Error saving Coder Connect settings: {ex.Message}");
         }
     }
 

App/Views/Pages/SettingsMainPage.xaml

@@ -44,12 +44,6 @@
                                        >
                     <ToggleSwitch IsOn="{x:Bind ViewModel.ConnectOnLaunch, Mode=TwoWay}" />
                 </controls:SettingsCard>
-                <controls:SettingsCard Description="This setting loosens some VPN loop protection checks in Coder Connect, allowing traffic to flow to a Coder deployment behind a corporate VPN. We only recommend enabling this option if Coder Connect doesn't work with your Coder deployment behind a corporate VPN."
-                       Header="Enable support for corporate VPNs"
-                       HeaderIcon="{ui:FontIcon Glyph=&#xE705;}"
-                       >
-                    <ToggleSwitch IsOn="{x:Bind ViewModel.DisableTailscaleLoopProtection, Mode=TwoWay}" />
-                </controls:SettingsCard>
             </StackPanel>
         </Grid>
     </ScrollViewer>

App/Views/SettingsWindow.xaml

@@ -9,8 +9,8 @@
     xmlns:winuiex="using:WinUIEx"
     mc:Ignorable="d"
     Title="Coder Settings"
-    Width="600" Height="500"
-    MinWidth="600" MinHeight="500">
+    Width="600" Height="350"
+    MinWidth="600" MinHeight="350">
 
     <Window.SystemBackdrop>
         <MicaBackdrop/>

App/Views/TrayWindow.xaml.cs

@@ -5,9 +5,11 @@
 using Coder.Desktop.App.Views.Pages;
 using CommunityToolkit.Mvvm.Input;
 using Microsoft.UI;
+using Microsoft.UI.Input;
 using Microsoft.UI.Windowing;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
+using Microsoft.UI.Xaml.Documents;
 using Microsoft.UI.Xaml.Media.Animation;
 using System;
 using System.Collections.Generic;
@@ -17,7 +19,6 @@
 using Windows.Graphics;
 using Windows.System;
 using Windows.UI.Core;
-using Microsoft.UI.Input;
 using WinRT.Interop;
 using WindowActivatedEventArgs = Microsoft.UI.Xaml.WindowActivatedEventArgs;
 
@@ -40,6 +41,7 @@ public sealed partial class TrayWindow : Window
 
     private readonly IRpcController _rpcController;
     private readonly ICredentialManager _credentialManager;
+    private readonly ISyncSessionController _syncSessionController;
     private readonly IUpdateController _updateController;
     private readonly IUserNotifier _userNotifier;
     private readonly TrayWindowLoadingPage _loadingPage;
@@ -49,13 +51,15 @@ public sealed partial class TrayWindow : Window
 
     public TrayWindow(
         IRpcController rpcController, ICredentialManager credentialManager,
-        IUpdateController updateController, IUserNotifier userNotifier,
+        ISyncSessionController syncSessionController, IUpdateController updateController,
+        IUserNotifier userNotifier,
         TrayWindowLoadingPage loadingPage,
         TrayWindowDisconnectedPage disconnectedPage, TrayWindowLoginRequiredPage loginRequiredPage,
         TrayWindowMainPage mainPage)
     {
         _rpcController = rpcController;
         _credentialManager = credentialManager;
+        _syncSessionController = syncSessionController;
         _updateController = updateController;
         _userNotifier = userNotifier;
         _loadingPage = loadingPage;
@@ -70,7 +74,9 @@ public TrayWindow(
 
         _rpcController.StateChanged += RpcController_StateChanged;
         _credentialManager.CredentialsChanged += CredentialManager_CredentialsChanged;
-        SetPageByState(_rpcController.GetState(), _credentialManager.GetCachedCredentials());
+        _syncSessionController.StateChanged += SyncSessionController_StateChanged;
+        SetPageByState(_rpcController.GetState(), _credentialManager.GetCachedCredentials(),
+            _syncSessionController.GetState());
 
         // Setting these directly in the .xaml doesn't seem to work for whatever reason.
         TrayIcon.OpenCommand = Tray_OpenCommand;
@@ -121,7 +127,8 @@ public TrayWindow(
         };
     }
 
-    private void SetPageByState(RpcModel rpcModel, CredentialModel credentialModel)
+    private void SetPageByState(RpcModel rpcModel, CredentialModel credentialModel,
+        SyncSessionControllerStateModel syncSessionModel)
     {
         if (credentialModel.State == CredentialState.Unknown)
         {
@@ -194,13 +201,18 @@ private void MaybeNotifyUser(RpcModel rpcModel)
 
     private void RpcController_StateChanged(object? _, RpcModel model)
     {
-        SetPageByState(model, _credentialManager.GetCachedCredentials());
+        SetPageByState(model, _credentialManager.GetCachedCredentials(), _syncSessionController.GetState());
         MaybeNotifyUser(model);
     }
 
     private void CredentialManager_CredentialsChanged(object? _, CredentialModel model)
     {
-        SetPageByState(_rpcController.GetState(), model);
+        SetPageByState(_rpcController.GetState(), model, _syncSessionController.GetState());
+    }
+
+    private void SyncSessionController_StateChanged(object? _, SyncSessionControllerStateModel model)
+    {
+        SetPageByState(_rpcController.GetState(), _credentialManager.GetCachedCredentials(), model);
     }
 
     // Sadly this is necessary because Window.Content.SizeChanged doesn't

Tests.App/Services/CredentialManagerTest.cs

@@ -317,10 +317,7 @@ public async Task SetDuringLoad(CancellationToken ct)
         var loadTask = manager.LoadCredentials(ct);
         // Then fully perform a set.
         await manager.SetCredentials(TestServerUrl, TestApiToken, ct).WaitAsync(ct);
-
-        // The load should complete with the new valid credentials
-        var result = await loadTask;
-        Assert.That(result.State, Is.EqualTo(CredentialState.Valid));
-        Assert.That(result.CoderUrl?.ToString(), Is.EqualTo(TestServerUrl));
+        // The load should have been cancelled.
+        Assert.ThrowsAsync<TaskCanceledException>(() => loadTask);
     }
 }

Vpn.Proto/vpn.proto

@@ -62,7 +62,7 @@ message ServiceMessage {
 		StartResponse start = 2;
 		StopResponse stop = 3;
 		Status status = 4;                // either in reply to a StatusRequest or broadcasted
-		StartProgress start_progress = 5; // broadcasted during startup (used exclusively by Windows)
+		StartProgress start_progress = 5; // broadcasted during startup
 	}
 }
 
@@ -214,7 +214,6 @@ message NetworkSettingsResponse {
 // StartResponse.
 message StartRequest {
 	int32 tunnel_file_descriptor = 1;
-	bool tunnel_use_soft_net_isolation = 8;
 	string coder_url = 2;
 	string api_token = 3;
 	// Additional HTTP headers added to all requests