Skip to content

Login page redesign #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deansheather opened this issue Mar 4, 2025 · 6 comments
Open

Login page redesign #39

deansheather opened this issue Mar 4, 2025 · 6 comments

Comments

@deansheather
Copy link
Member

deansheather commented Mar 4, 2025

Use Christin's design in Slack for redesigning the login page.

Image

Relates to #22

@phorcys420
Copy link
Member

phorcys420 commented Apr 21, 2025

We should also make the "Server URL" field enter-able (i.e pressing enter) if that wasn't already taken into account.

Image


Other thoughts :

  • The "main" field should be focused when switching back to the login window (e.g "Server URL", and then "Session Token")
  • The fields should be autofilled if the data meets expectations (for "Server URL", just parse the clipboard data to check if it's a URL, for "Session Token", i think just do whatever the VSCode extension is doing)

@ibetitsmike
Copy link
Contributor

@phorcys420 I've implemented the enter part in a separate issue.

Auto pasting URI sounds like a bad idea, with the token I'd also prefer users to actually "paste it in". I would however consider clearing their clipboard after login so they don't accidentialy paste it somewhere else.

@phorcys420
Copy link
Member

@ibetitsmike what's so bad about auto pasting the URI?

Also, regarding the token, that's just how the VSCode extension works, so I think we'd want to be on the same page for that.

@ibetitsmike
Copy link
Contributor

I think I could be fine with automatically pasting the URI - cause you see it and can change if desired.

The token is masked so the user doesn't necessarily know if he pasted in the correct thing. And how does the VS Code extension know when the clipboard contains the token? It does a pattern check?

@phorcys420
Copy link
Member

@matifali
Copy link
Member

@deansheather moving this as a GA candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants