-
Notifications
You must be signed in to change notification settings - Fork 3
Login page redesign #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We should also make the "Server URL" field enter-able (i.e pressing enter) if that wasn't already taken into account. Other thoughts :
|
@phorcys420 I've implemented the enter part in a separate issue. Auto pasting URI sounds like a bad idea, with the token I'd also prefer users to actually "paste it in". I would however consider clearing their clipboard after login so they don't accidentialy paste it somewhere else. |
@ibetitsmike what's so bad about auto pasting the URI? Also, regarding the token, that's just how the VSCode extension works, so I think we'd want to be on the same page for that. |
I think I could be fine with automatically pasting the URI - cause you see it and can change if desired. The token is masked so the user doesn't necessarily know if he pasted in the correct thing. And how does the VS Code extension know when the clipboard contains the token? It does a pattern check? |
@ibetitsmike it just validates it against the server https://github.com/coder/vscode-coder/blob/main/src%2Fcommands.ts#L243-L264 |
@deansheather moving this as a GA candidate. |
Uh oh!
There was an error while loading. Please reload this page.
Use Christin's design in Slack for redesigning the login page.
Relates to #22
The text was updated successfully, but these errors were encountered: