Skip to content

Commit c5e2428

Browse files
committed
Improve test coverage
1 parent 9c8f1d1 commit c5e2428

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

websocket.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -846,8 +846,9 @@ func (c *Conn) ping(ctx context.Context) error {
846846
case <-c.closed:
847847
return c.closeErr
848848
case <-ctx.Done():
849-
c.close(xerrors.Errorf("failed to ping: %w", ctx.Err()))
850-
return ctx.Err()
849+
err := xerrors.Errorf("failed to wait for pong: %w", ctx.Err())
850+
c.close(err)
851+
return err
851852
case <-pong:
852853
return nil
853854
}

websocket_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ func TestHandshake(t *testing.T) {
263263
if err != nil {
264264
return err
265265
}
266-
// Read twice to ensure the un EOFed previous reader works correctly.
267266
err = read()
268267
if err != nil {
269268
return err
@@ -843,11 +842,6 @@ func benchConn(b *testing.B, echo, stream bool, size int) {
843842
if err != nil {
844843
b.Fatal(err)
845844
}
846-
847-
_, err = r.Read([]byte{0})
848-
if !xerrors.Is(err, io.EOF) {
849-
b.Fatalf("more data in reader than needed")
850-
}
851845
}
852846
}
853847
b.StopTimer()

0 commit comments

Comments
 (0)