Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e43d9ad

Browse files
committedJun 20, 2019
Improve docs and CI
1 parent 8c04993 commit e43d9ad

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed
 

‎ci/fmt/entrypoint.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
source ci/lib.sh || exit 1
44

5+
unstaged_files() {
6+
git ls-files --other --modified --exclude-standard
7+
}
8+
59
gen() {
610
# Unfortunately, this is the only way to ensure go.mod and go.sum are correct.
711
# See https://github.com/golang/go/issues/27005
@@ -25,7 +29,7 @@ if [[ $CI && $(unstaged_files) != "" ]]; then
2529
echo
2630
echo "files either need generation or are formatted incorrectly"
2731
echo "please run:"
28-
echo "./test.sh"
32+
echo "./ci/run.sh"
2933
echo
3034
git status
3135
exit 1

‎ci/lib.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,3 @@ export CI=${GITHUB_ACTION-}
1212
if [[ $CI ]]; then
1313
export GOFLAGS=-mod=readonly
1414
fi
15-
16-
unstaged_files() {
17-
git ls-files --other --modified --exclude-standard
18-
}

‎dial.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ type DialOptions struct {
3636
// If an error occurs, the returned response may be non nil. However, you can only
3737
// read the first 1024 bytes of its body.
3838
//
39+
// You never need to close the resp.Body yourself.
40+
//
3941
// This function requires at least Go 1.12 to succeed as it uses a new feature
4042
// in net/http to perform WebSocket handshakes and get a writable body
4143
// from the transport. See https://github.com/golang/go/issues/26937#issuecomment-415855861

0 commit comments

Comments
 (0)
Please sign in to comment.