test: move the Wasm NetConn read limit test to its own file

The fix-close-race-net-errclosed branch adds a test at the same place in
ws_js_test.go, and the two insertions conflict on merge.

Author: mafredri

netconn_js_test.go

@@ -0,0 +1,70 @@
+package websocket_test
+
+import (
+	"context"
+	"io"
+	"net"
+	"os"
+	"testing"
+	"time"
+
+	"github.com/coder/websocket"
+	"github.com/coder/websocket/internal/test/assert"
+	"github.com/coder/websocket/internal/test/xrand"
+)
+
+func TestWasmNetConnReadLimit(t *testing.T) {
+	t.Parallel()
+
+	for _, tc := range []struct {
+		name    string
+		netConn func(ctx context.Context, c *websocket.Conn) net.Conn
+		msgSize int
+		wantErr error
+	}{
+		{"Unset", func(ctx context.Context, c *websocket.Conn) net.Conn {
+			return websocket.NetConn(ctx, c, websocket.MessageBinary)
+		}, 65536, nil},
+		{"DisabledBeforeNetConn", func(ctx context.Context, c *websocket.Conn) net.Conn {
+			c.SetReadLimit(-1)
+			return websocket.NetConn(ctx, c, websocket.MessageBinary)
+		}, 65536, nil},
+		{"BeforeNetConn", func(ctx context.Context, c *websocket.Conn) net.Conn {
+			c.SetReadLimit(1024)
+			return websocket.NetConn(ctx, c, websocket.MessageBinary)
+		}, 4096, websocket.ErrMessageTooBig},
+		{"AfterNetConn", func(ctx context.Context, c *websocket.Conn) net.Conn {
+			nc := websocket.NetConn(ctx, c, websocket.MessageBinary)
+			c.SetReadLimit(1024)
+			return nc
+		}, 4096, websocket.ErrMessageTooBig},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
+			ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
+			defer cancel()
+
+			c, _, err := websocket.Dial(ctx, os.Getenv("WS_ECHO_SERVER_URL"), &websocket.DialOptions{
+				Subprotocols: []string{"echo"},
+			})
+			assert.Success(t, err)
+			// The echo server expects StatusNormalClosure.
+			defer c.Close(websocket.StatusNormalClosure, "")
+
+			nc := tc.netConn(ctx, c)
+			msg := []byte(xrand.String(tc.msgSize))
+			_, err = nc.Write(msg)
+			assert.Success(t, err)
+
+			got := make([]byte, len(msg))
+			_, err = io.ReadFull(nc, got)
+			if tc.wantErr != nil {
+				assert.ErrorIs(t, tc.wantErr, err)
+				return
+			}
+			assert.Success(t, err)
+			assert.Equal(t, "read msg", msg, got)
+		})
+	}
+}

ws_js_test.go

@@ -2,8 +2,6 @@ package websocket_test
 
 import (
 	"context"
-	"io"
-	"net"
 	"net/http"
 	"os"
 	"testing"
@@ -12,7 +10,6 @@ import (
 	"github.com/coder/websocket"
 	"github.com/coder/websocket/internal/test/assert"
 	"github.com/coder/websocket/internal/test/wstest"
-	"github.com/coder/websocket/internal/test/xrand"
 )
 
 func TestWasm(t *testing.T) {
@@ -40,62 +37,6 @@ func TestWasm(t *testing.T) {
 	assert.Success(t, err)
 }
 
-func TestWasmNetConnReadLimit(t *testing.T) {
-	t.Parallel()
-
-	for _, tc := range []struct {
-		name    string
-		netConn func(ctx context.Context, c *websocket.Conn) net.Conn
-		msgSize int
-		wantErr error
-	}{
-		{"Unset", func(ctx context.Context, c *websocket.Conn) net.Conn {
-			return websocket.NetConn(ctx, c, websocket.MessageBinary)
-		}, 65536, nil},
-		{"DisabledBeforeNetConn", func(ctx context.Context, c *websocket.Conn) net.Conn {
-			c.SetReadLimit(-1)
-			return websocket.NetConn(ctx, c, websocket.MessageBinary)
-		}, 65536, nil},
-		{"BeforeNetConn", func(ctx context.Context, c *websocket.Conn) net.Conn {
-			c.SetReadLimit(1024)
-			return websocket.NetConn(ctx, c, websocket.MessageBinary)
-		}, 4096, websocket.ErrMessageTooBig},
-		{"AfterNetConn", func(ctx context.Context, c *websocket.Conn) net.Conn {
-			nc := websocket.NetConn(ctx, c, websocket.MessageBinary)
-			c.SetReadLimit(1024)
-			return nc
-		}, 4096, websocket.ErrMessageTooBig},
-	} {
-		t.Run(tc.name, func(t *testing.T) {
-			t.Parallel()
-
-			ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
-			defer cancel()
-
-			c, _, err := websocket.Dial(ctx, os.Getenv("WS_ECHO_SERVER_URL"), &websocket.DialOptions{
-				Subprotocols: []string{"echo"},
-			})
-			assert.Success(t, err)
-			// The echo server expects StatusNormalClosure.
-			defer c.Close(websocket.StatusNormalClosure, "")
-
-			nc := tc.netConn(ctx, c)
-			msg := []byte(xrand.String(tc.msgSize))
-			_, err = nc.Write(msg)
-			assert.Success(t, err)
-
-			got := make([]byte, len(msg))
-			_, err = io.ReadFull(nc, got)
-			if tc.wantErr != nil {
-				assert.ErrorIs(t, tc.wantErr, err)
-				return
-			}
-			assert.Success(t, err)
-			assert.Equal(t, "read msg", msg, got)
-		})
-	}
-}
-
 func TestWasmDialTimeout(t *testing.T) {
 	t.Parallel()