- version 0.9.2.11

- finalizing mplayer recording
- starting vlc recording (disabled at the moment)
- a python 2 fix

Author: s-n-g

Changelog

@@ -1,3 +1,9 @@
+2023-06-20 s-n-g
+    * version 0.9.2.11
+    * implementing station recording for MPlayer media player
+    * players' config file will be backed up on Windows
+    * fixing a couple of potential crashes
+
 2023-06-14 s-n-g
     * version 0.9.2.10
     * all PyRadio threads will terminate when Alt-F4 or the
@@ -14,7 +20,7 @@
 2023-06-13 s-n-g
     * version 0.9.2.8
     * \o will open the config directory in a file manager
-    * implementing station recording vor MPV media player
+    * implementing station recording for MPV media player
     * implementing playback pause for MPV media player, when
       player in recording mode
     * fixing Windows installayion scripts

README.html

@@ -207,6 +207,12 @@ <h2 id="requirements">Requirements <span style="padding-left: 10px;"><sup style=
 <h2 id="changelog">Changelog <span style="padding-left: 10px;"><sup style="font-size: 50%"><a href="#" title="Go to top of the page">Top</a></sup></span></h2>
 <pre style="height: 200px;">
 
+2023-06-20 s-n-g
+    * version 0.9.2.11
+    * implementing station recording for MPlayer media player
+    * players' config file will be backed up on Windows
+    * fixing a couple of potential crashes
+
 2023-06-14 s-n-g
     * version 0.9.2.10
     * all PyRadio threads will terminate when Alt-F4 or the
@@ -223,7 +229,7 @@ <h2 id="changelog">Changelog <span style="padding-left: 10px;"><sup style="font-
 2023-06-13 s-n-g
     * version 0.9.2.8
     * \o will open the config directory in a file manager
-    * implementing station recording vor MPV media player
+    * implementing station recording for MPV media player
     * implementing playback pause for MPV media player, when
       player in recording mode
     * fixing Windows installayion scripts

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyradio"
-version = "0.9.2.10"
+version = "0.9.2.11"
 authors = [
   { name="Ben Dowling", email="[email protected]" },
   { name="Spiros Georgaras", email="[email protected]" },

pyradio/__init__.py

@@ -1,6 +1,6 @@
 " pyradio -- Console radio player. "
 
-version_info = (0, 9, 2, 10)
+version_info = (0, 9, 2, 11)
 
 # Set it to True if new stations have been
 # added to the package's stations.csv

pyradio/config.py

@@ -13,7 +13,10 @@
 from shutil import copyfile, move, Error as shutil_Error
 import threading
 from copy import deepcopy
-from subprocess import Popen, DEVNULL
+try:
+    from subprocess import Popen, DEVNULL
+except ImportError:
+    from subprocess import Popen
 from platform import system
 if system().lower() == 'windows':
     from os import startfile

pyradio/install.py

@@ -15,7 +15,7 @@
 ''' This is PyRadio version this
     install.py was released for
 '''
-PyRadioInstallPyReleaseVersion = '0.9.2.10'
+PyRadioInstallPyReleaseVersion = '0.9.2.11'
 
 import locale
 locale.setlocale(locale.LC_ALL, "")

pyradio/player.py

@@ -316,7 +316,7 @@ def recording(self, val):
             self._recording = 0
         logger.error('\n\nsetting recording to {}'.format(self._recording))
 
-    def getrecording_filename(self, name, extension):
+    def get_recording_filename(self, name, extension):
         f = datetime.now().strftime('%Y-%m-%d %H-%M-%S') + " " + name + extension
         return os.path.join(self._cnf.recording_dir, f)
 
@@ -397,6 +397,35 @@ def set_volume(self, vol):
                 while old_vol == int(self.volume):
                     sleep(.1)
 
+    def create_monitor_player(self, stop):
+        logger.info('\n\n======|||==========')
+        # self.monitor_opts.append('--volume')
+        # self.monitor_opts.append('300')
+        logger.info(self.monitor_opts)
+        while not os.path.exists(self.recording_filename):
+            sleep(.1)
+            if stop():
+                logger.error('Asked to stop. Exiting....')
+                return
+        while os.path.getsize(self.recording_filename) < 12000:
+            sleep(.1)
+            if stop():
+                logger.error('Asked to stop. Exiting....')
+                return
+        if stop():
+            logger.error('Asked to stop. Exiting....')
+            return
+        if logger.isEnabledFor(logging.INFO):
+            logger.info('\n\n')
+            logger.info('----==== {} monitor started ====----'.format(self.PLAYER_NAME))
+            logger.info('\n\n')
+        self.monitor_process = subprocess.Popen(
+            self.monitor_opts, shell=False,
+            stdout=subprocess.PIPE,
+            stdin=subprocess.PIPE,
+            stderr=subprocess.STDOUT
+        )
+
     def save_volume(self):
         pass
 
@@ -1570,11 +1599,17 @@ def play(self,
             logger.info('----==== {} player started ====----'.format(self.PLAYER_NAME))
         if self.recording == self.RECORD_AND_LISTEN \
                 and self.PLAYER_NAME != 'mpv':
-            threading.Thread(
-                    target=self.create_monitor_player,
-                    args=(lambda: self.stop_mpv_status_update_thread or \
-                            self.stop_win_vlc_status_update_thread,  )
-                    ).start()
+                    if self.PLAYER_NAME == 'mplayer':
+                        threading.Thread(
+                                target=self.create_monitor_player,
+                                args=(lambda: self.stop_mpv_status_update_thread or \
+                                        self.stop_win_vlc_status_update_thread,  )
+                                ).start()
+                    else:
+                        threading.Thread(
+                                target=self.create_monitor_player,
+                                args=(lambda: self.stop_mpv_status_update_thread, )
+                                ).start()
 
     def _sendCommand(self, command):
         ''' send keystroke command to player '''
@@ -1972,7 +2007,7 @@ def _buildStartOpts(self, streamUrl, playList=False):
 
         logger.error('\n\nself._recording = {}'.format(self._recording))
         if self._recording > 0:
-            self.recording_filename = self.getrecording_filename(self.name, '.mkv')
+            self.recording_filename = self.get_recording_filename(self.name, '.mkv')
             opts.append('--stream-record=' + self.recording_filename)
             if logger.isEnabledFor(logging.DEBUG):
                 logger.debug('---=== Starting Recording: "{}" ===---',format(self.recording_filename))
@@ -2357,29 +2392,6 @@ def __init__(self,
         )
         self.config_files = self.all_config_files['mplayer']
 
-    def create_monitor_player(self, stop):
-        while not os.path.exists(self.recording_filename):
-            sleep(.1)
-            if stop():
-                logger.error('Asked to stop. Exiting....')
-                return
-        while os.path.getsize(self.recording_filename) < 500:
-            sleep(.1)
-            if stop():
-                logger.error('Asked to stop. Exiting....')
-                return
-        if stop():
-            logger.error('Asked to stop. Exiting....')
-            return
-        if logger.isEnabledFor(logging.INFO):
-            logger.info('----==== {} monitor started ====----'.format(self.PLAYER_NAME))
-        self.monitor_process = subprocess.Popen(
-            self.monitor_opts, shell=False,
-            stdout=subprocess.PIPE,
-            stdin=subprocess.PIPE,
-            stderr=subprocess.STDOUT
-        )
-
     def save_volume(self):
         if platform.startswith('win'):
             return self._do_save_volume('volume={}\r\n')
@@ -2485,7 +2497,7 @@ def _buildStartOpts(self, streamUrl, playList=False):
                 ''' not -playlist, find and remove url '''
                 i = [y for y, x in enumerate(monitor_opts) if x == streamUrl][0]
                 del monitor_opts[i]
-            self.recording_filename = self.getrecording_filename(self.name, '.mkv')
+            self.recording_filename = self.get_recording_filename(self.name, '.mkv')
             monitor_opts.append(self.recording_filename)
             opts.append('-dumpstream')
             opts.append('-dumpfile')
@@ -2725,7 +2737,10 @@ def _buildStartOpts(self, streamUrl, playList=False):
                 logger.info('vlc log file: "{}"'.format(self._vlc_stdout_log_file))
 
         else:
-            opts = [self.PLAYER_CMD, '-Irc', '-vv', self._url_to_use(streamUrl)]
+            if self.recording == self.NO_RECORDING:
+                opts = [self.PLAYER_CMD, '-Irc', '-vv', self._url_to_use(streamUrl)]
+            else:
+                opts = [self.PLAYER_CMD, '--no-one-instance', '-Irc', '-vv', self._url_to_use(streamUrl)]
 
 
         ''' take care of command line parameters '''
@@ -2742,10 +2757,14 @@ def _buildStartOpts(self, streamUrl, playList=False):
         ## opts.append(r'file/ts:C:\Users\Spiros\AppData\Roaming\pyradio\recordings\rec.mkv')
         logger.error('\n\nself._recording = {}'.format(self._recording))
         if self._recording > 0:
-            self.recording_filename = self.getrecording_filename(self.name, '.mkv')
+            monitor_opts = opts[:]
+            i = [y for y, x in enumerate(monitor_opts) if x == streamUrl][0]
+            del monitor_opts[i]
+            self.recording_filename = self.get_recording_filename(self.name, '.mkv')
             opts.append('--sout')
             opts.append(r'file/ts:' + self.recording_filename)
             opts.append(self.recording_filename)
+            monitor_opts.append(self.recording_filename)
             if logger.isEnabledFor(logging.DEBUG):
                 logger.debug('---=== Starting Recording: "{}" ===---',format(self.recording_filename))
         return opts, monitor_opts

pyradio/radio.py

@@ -8620,17 +8620,19 @@ def keypress(self, char):
             if self.ws.operation_mode == self.ws.NORMAL_MODE:
                 if char == ord('|'):
                     self._reset_status_bar_right()
-                    # if self.player.PLAYER_NAME == 'mpv':
-                    self.player.recording = 1 if self.player.recording == 0 else 0
-                    if self.player.recording > 0:
-                        if self.player.isPlaying():
-                            self.player.already_playing = True
+                    if self.player.PLAYER_NAME != 'vlc':
+                        self.player.recording = 1 if self.player.recording == 0 else 0
+                        if self.player.recording > 0:
+                            if self.player.isPlaying():
+                                self.player.already_playing = True
+                            else:
+                                self.player.already_playing = False
                         else:
                             self.player.already_playing = False
+                        self._show_recording_status_in_header()
+                        self._show_recording_toggle_window()
                     else:
-                        self.player.already_playing = False
-                    self._show_recording_status_in_header()
-                    self._show_recording_toggle_window()
+                        self._print_not_implemented_yet()
 
                 elif char == curses.ascii.BEL:
                     ''' ^G - show groups '''
@@ -8868,6 +8870,9 @@ def keypress(self, char):
                 elif char in (curses.KEY_ENTER,
                               ord('\n'), ord('\r'),
                               curses.KEY_RIGHT, ord('l')):
+                    if self.player.isPlaying() and \
+                            self.player.playback_is_on:
+                        self._stop_player()
                     self._start_player()
                     self._do_display_notify()
                     return

recording.html

@@ -68,31 +68,41 @@ <h2 id="table-of-contents">Table of Contents <span style="padding-left: 10px;"><
 <h2 id="intro">Intro <span style="padding-left: 10px;"><sup style="font-size: 50%"><a href="#" title="Go to top of the page">Top</a></sup></span></h2>
 <p><strong>PyRadio v. 0.9.2.8</strong> introduces the ability to record stations, a feature used mainly to facilitate another feature: the ability to <em>pause and resume playback</em>.</p>
 <p>All supported media players (<strong>MPV</strong>, <strong>MPlayer</strong> and <strong>VLC</strong>) support stream recording, each implementing it in a different way, which pose a challenge for the front end implementation.</p>
-<p>Let us see the differences.</p>
+<p>Before we see the differences, let us talk about some things that will make the whole thing easier to understand.</p>
+<p>When it comes to recording a stream the program has to provide two things:</p>
+<ol type="1">
+<li><p>a <strong>recorder</strong>, which is the component that will connect to the stream (in our case the station), receive its data, and write them in a file that media players can recognize and reproduce.<br />
+<br />
+Since this is the program receiving data from the station, it will also receive song titles, or other stations data, but will not save them to the recorded file.</p></li>
+<li><p>a <strong>monitor</strong>, which is the component that will reproduce the saved stream so that the user can monitor what is being downloaded.<br />
+<br />
+The <strong>monitor</strong> will just reproduce what’s written to the file by the <strong>recorder</strong>, so it knows nothing about a station, it’s data and song titles transmitted by it.</p></li>
+</ol>
+<p>Now, let’s see how <strong>PyRadio</strong>’s supported players behave.</p>
 <h3 id="mpv">MPV</h3>
 <p><strong>MPV</strong> stream recording has the following characteristics:</p>
 <ul>
-<li>it is done using the <strong>–stream-record</strong> command line parameter.</li>
 <li>it is considered an <strong>experimental feature</strong> by the <strong>MPV</strong> developers.<br />
 Radio streaming uses well known and established codecs (mainly mp3 and aac) and I have had no broken recording while testing the feature (even with flac stations).</li>
-<li><strong>MPV</strong> has the ability to play and record a stream at the same time.<br />
+<li><strong>MPV</strong> has the ability to play and record a stream at the same time (both the <strong>recorder</strong> and the <strong>monitor</strong> components are active simultaneously).<br />
 This is very convenient, since all one has to do is add a command line parameter and start recording, while listening to what’s being recorded.</li>
 <li>adjusting the volume or muting the player will not affect what’s being recorded.</li>
 <li>when paused, the player will pause the playback but will keep recording the stream. Furthermore, song titles will stop being updated, but will be correctly displayed and updated when playback is resumed.</li>
 </ul>
 <h3 id="mplayer">MPlayer</h3>
-<p><strong>Note</strong>: <strong>MPlayer</strong> recording has not been implemented yet!</p>
 <p><strong>MPlayer</strong> stream recording has the following characteristics:</p>
 <ul>
-<li>it is done using the <strong>-dumpstream</strong> and <strong>-dumpfile</strong> command line parameters.</li>
 <li>it does not have the ability to record and play a stream at the same time.<br />
-This means that the front end will have to use two <em>mplayer</em> instances: one to record the stream and one more to play the recorded file (as it is being recorded).</li>
+This means that the front end (<strong>PyRadio</strong>) will have to use two <em>mplayer</em> instances (run <em>mplayer</em> twice): one as a <strong>recorder</strong> and one as a <strong>monitor</strong>.</li>
+<li>the <strong>recorder</strong> will display the song titles in addition to saving the output file.</li>
+<li>the <strong>monitor</strong> will be started after the output file gets to a certain size, set to 12000 bytes by trial and error.</li>
+<li>pausing and resuming the <strong>monitor</strong> for long will lead to song titles being out of sync, since the <strong>recorder</strong> will keep receiving data (and song titles) even when the playback if off.</li>
+<li>adjusting the playback volume is of course possible, but there will be no vissible indication for it.</li>
 </ul>
 <h3 id="vlc">VLC</h3>
 <p><strong>Note</strong>: <strong>VLC</strong> recording has not been implemented yet!</p>
 <p><strong>VLC</strong> stream recording has the following characteristics:</p>
 <ul>
-<li>it is done using the <strong>–sout</strong> command line parameter.</li>
 <li>it does not have the ability to record and play a stream at the same time.<br />
 This means that the front end will have to use two <em>vlc</em> instances: one to record the stream and one more to play the recorded file (as it is being recorded).</li>
 </ul>

recording.md

@@ -39,37 +39,48 @@ ___
 
 All supported media players (**MPV**, **MPlayer** and **VLC**) support stream recording, each implementing it in a different way, which pose a challenge for the front end implementation.
 
-Let us see the differences.
+Before we see the differences, let us talk about some things that will make the whole thing easier to understand.
+
+When it comes to recording a stream the program has to provide two things:
+
+1. a **recorder**, which is the component that will connect to the stream (in our case the station), receive its data, and write them in a file that media players can recognize and reproduce. \
+\
+Since this is the program receiving data from the station, it will also receive song titles, or other stations data, but will not save them to the recorded file.
+
+2. a **monitor**, which is the component that will reproduce the saved stream so that the user can monitor what is being downloaded. \
+\
+The **monitor** will just reproduce what's written to the file by the **recorder**, so it knows nothing about a station, it's data and song titles transmitted by it.
+
+Now, let's see how **PyRadio**'s supported players behave.
 
 ### MPV
 
 **MPV** stream recording has the following characteristics:
 
-- it is done using the **--stream-record** command line parameter.
 - it is considered an **experimental feature** by the **MPV** developers. \
 Radio streaming uses well known and established codecs (mainly mp3 and aac) and I have had no broken recording while testing the feature (even with flac stations).
-- **MPV** has the ability to play and record a stream at the same time. \
+- **MPV** has the ability to play and record a stream at the same time (both the **recorder** and the **monitor** components are active simultaneously). \
 This is very convenient, since all one has to do is add a command line parameter and start recording, while listening to what's being recorded.
 - adjusting the volume or muting the player will not affect what's being recorded.
 - when paused, the player will pause the playback but will keep recording the stream. Furthermore, song titles will stop being updated, but will be correctly displayed and updated when playback is resumed.
 
 ### MPlayer
 
-**Note**: **MPlayer** recording has not been implemented yet!
-
 **MPlayer** stream recording has the following characteristics:
 
-- it is done using the **-dumpstream** and **-dumpfile** command line parameters.
 - it does not have the ability to record and play a stream at the same time. \
-This means that the front end will have to use two *mplayer* instances: one to record the stream and one more to play the recorded file (as it is being recorded).
+This means that the front end (**PyRadio**) will have to use two *mplayer* instances (run *mplayer* twice): one as a **recorder** and one as a **monitor**.
+- the **recorder** will display the song titles in addition to saving the output file.
+- the **monitor** will be started after the output file gets to a certain size, set to 12000 bytes by trial and error.
+- pausing and resuming the **monitor** for long will lead to song titles being out of sync, since the **recorder** will keep receiving data (and song titles) even when the playback if off.
+- adjusting the playback volume is of course possible, but there will be no vissible indication for it.
 
 ### VLC
 
 **Note**: **VLC** recording has not been implemented yet!
 
 **VLC** stream recording has the following characteristics:
 
-- it is done using the **--sout** command line parameter.
 - it does not have the ability to record and play a stream at the same time. \
 This means that the front end will have to use two *vlc* instances: one to record the stream and one more to play the recorded file (as it is being recorded).