Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup error #431

Closed
simison opened this issue Jan 8, 2016 · 9 comments
Closed

Signup error #431

simison opened this issue Jan 8, 2016 · 9 comments

Comments

@simison
Copy link

simison commented Jan 8, 2016

  1. Clicked "Sign up" —> "Authorize" (at GitHub) —> "Something went wrong" error at the site.
  2. Came back to the front page —> Click "Sign up" —> Works! (directly, skips the GitHub phase)

Possibly related to #387 ?

GitHub API upgraded to 3.0, something to do with that?

@schneems
Copy link
Member

schneems commented Jan 8, 2016

Seeing it too

2016-01-08T20:38:23.835130+00:00 app[web.3]: ActionView::Template::Error (undefined method `new_user_registration_path' for #<ActionDispatch::Routing::RoutesProxy:0x007fece81b1548>):
2016-01-08T20:38:23.835131+00:00 app[web.3]:     3: <% end -%>
2016-01-08T20:38:23.835132+00:00 app[web.3]:     4:
2016-01-08T20:38:23.835133+00:00 app[web.3]:     5: <%- if devise_mapping.registerable? && controller_name != 'registrations' %>
2016-01-08T20:38:23.835134+00:00 app[web.3]:     6:   <%= link_to "Sign up", new_registration_path(resource_name) %><br />
2016-01-08T20:38:23.835134+00:00 app[web.3]:     7: <% end -%>
2016-01-08T20:38:23.835135+00:00 app[web.3]:     8:
2016-01-08T20:38:23.835136+00:00 app[web.3]:     9: <%- if devise_mapping.recoverable? && controller_name != 'passwords' && controller_name != 'registrations' %>

Not sure why this just started being an issue?

Ahh

2016-01-08T20:38:23.441231+00:00 app[web.2]: [5a6f8272-79a0-4aa5-9c20-0af25c8f925c] Started GET "/users/auth/github/callback?code=<redacted>&state=<redacted>" for 72.48.77.213 at 2016-01-08 20:38:23 +0000
2016-01-08T20:38:23.475097+00:00 app[web.2]: E, [2016-01-08T20:38:23.475014 #6] ERROR -- omniauth: (github) Authentication failure! invalid_credentials: OAuth2::Error, bad_verification_code: The code passed is incorrect or expired.

thanks github :(

@simison
Copy link
Author

simison commented Jan 8, 2016

Recommend to follow https://developer.github.com/changes/ ;-)

@schneems
Copy link
Member

schneems commented Jan 8, 2016

If you hit it multiple times it works sometimes. I don't think this is a change to the API.

schneems added a commit that referenced this issue Jan 8, 2016
schneems added a commit that referenced this issue Jan 8, 2016
@schneems
Copy link
Member

schneems commented Jan 8, 2016

Potential fix: 4186732

@schneems
Copy link
Member

schneems commented Jan 8, 2016

works for me, let me know about you.

schneems added a commit that referenced this issue Jan 12, 2016
schneems added a commit that referenced this issue Jan 12, 2016
@prathamesh-sonpatki
Copy link
Member

@simison Are you still experiencing this?

@alfie-max
Copy link

@schneems shall we close this one out? seems like this isn't an issue any more.

@prathamesh-sonpatki
Copy link
Member

Thanks @alfie-max, giving it a close, we can reopen if this is still valid!

@bluet
Copy link

bluet commented Nov 4, 2022

I'm experiencing similar issue in #1671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants