Skip to content

Commit f489c3f

Browse files
committed
[CMAKE] Clear CMAKE_<LANGUAGE>_IMPLICIT_LINK_LIBRARIES and
_IMPLICIT_LINK_DIRECTORIES Othrewise, if you link a RC module with a static C library (as done for fusion DLLs), you get the standard C libraries from GCC. This is not what we want. This might have to be done for MSVC builds. Check build.ninja to verify this.
1 parent 157a509 commit f489c3f

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

overrides-gcc.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,6 @@ foreach(lang C CXX ASM)
33
set(CMAKE_${lang}_FLAGS_MINSIZEREL "-Os -DNDEBUG")
44
set(CMAKE_${lang}_FLAGS_RELEASE "")
55
set(CMAKE_${lang}_FLAGS_RELWITHDEBINFO "-O2 -g -DNDEBUG")
6+
set(CMAKE_${lang}_IMPLICIT_LINK_LIBRARIES "")
7+
set(CMAKE_${lang}_IMPLICIT_LINK_DIRECTORIES "")
68
endforeach()

sdk/cmake/gcc.cmake

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ if(CMAKE_C_COMPILER_ID STREQUAL "Clang")
6363
set(CMAKE_CXX_COMPILE_OPTIONS_PIE "")
6464
set(CMAKE_SHARED_LIBRARY_C_FLAGS "")
6565
set(CMAKE_SHARED_LIBRARY_CXX_FLAGS "")
66+
set(CMAKE_SHARED_MODULE_C_FLAGS "")
67+
set(CMAKE_SHARED_MODULE_CXX_FLAGS "")
6668
set(CMAKE_ASM_FLAGS_DEBUG "")
6769
set(CMAKE_C_FLAGS_DEBUG "")
6870
set(CMAKE_CXX_FLAGS_DEBUG "")
@@ -105,6 +107,9 @@ endif()
105107
if(DEFINED CMAKE_SHARED_LIBRARY_ASM_FLAGS)
106108
string(REPLACE "-fPIC" "" CMAKE_SHARED_LIBRARY_ASM_FLAGS ${CMAKE_SHARED_LIBRARY_ASM_FLAGS})
107109
endif()
110+
if(DEFINED CMAKE_SHARED_MODULE_ASM_FLAGS)
111+
string(REPLACE "-fPIC" "" CMAKE_SHARED_MODULE_ASM_FLAGS ${CMAKE_SHARED_MODULE_ASM_FLAGS})
112+
endif()
108113

109114
# Tuning
110115
if(ARCH STREQUAL "i386")

0 commit comments

Comments
 (0)