Skip to content

Fix #125 [LINE Client] 400: A message (messages[1]) in the request body is invalid #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2019

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented May 4, 2019

1.Fixes #125, createArticleShareReply uri size larger than 1000 cause [LINE Client] 400
A Chinese character creates 9 encoded characters. With article-url, queries, predefined words etc. reason size should be less than 100 (line:70, facebook:80).

2.Add createArticleShareReply test to decrease the possibility of occurring the same issue.

nonumpa added 2 commits May 4, 2019 13:05
…LINE Client] 400

A Chinese character creates 9 encoded characters, with article-url, queries, predefined words etc. reason size should be less than 100.
@nonumpa nonumpa requested review from MrOrz, godgunman and changhc May 4, 2019 05:23
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thank you so much for the effort!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 516

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 88.353%

Totals Coverage Status
Change from base Build 505: 0.4%
Covered Lines: 153
Relevant Lines: 169

💛 - Coveralls

@MrOrz MrOrz merged commit 52a6831 into dev May 4, 2019
@MrOrz MrOrz deleted the issue/125-uri-too-long branch May 4, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LINE Client] 400: A message (messages[1]) in the request body is invalid.
3 participants