Disparity between coil2 and coil3's equality delegate

[saket]

While migrating telephoto to coil3, I noticed that some of my tests were running into infinite loops of image requests because the new equality delegate does not account for non-ImageRequest models.

Coil 2.x	Coil 3.x

Was this an intention choice?

Here's how I'm using AsyncImageModelEqualityDelegate: https://github.com/saket/telephoto/blob/5d156f836441b2deb684427162ac22d5d00f29a6/zoomable-image/coil3/src/main/kotlin/me/saket/telephoto/zoomable/coil3/ZoomableAsyncImage.kt#L112

It's also interesting that AsyncImage() does not seem to run into this problem. Are you relying on something else for diffing non-ImageRequest models?

[colinrtwhite]

Good catch! This is definitely a bug. Added a fix here that we can ship in a 3.0.1 release.

There are a bunch of tests around when AsyncImage/rememberAsyncImagePainter recompose here. I think it might be recomposing infinitely for you because Coil has overloads here that wrap passing the AsyncImageState to the "real" stable, restartable implementation here.

[saket]

That was fast, thank you!