Merge pull request #25 from coinbase-samples/endpoint-fix

Endpoint fix

Author: nmorgan-cb

.gitignore

@@ -22,4 +22,6 @@ tmp/
 ai-docs/
 
 # OpenAPI spec - fetch dynamically instead of committing
-apiSpec/*.yaml
+apiSpec/*.yaml
+
+.java-version

CHANGELOG.md

@@ -1,5 +1,63 @@
 # Changelog
 
+## [1.5.0] - 2025-10-28
+
+### Added
+
+#### Orders Service - Advanced Order Type Support
+- **CreateOrderRequest**: Added support for advanced order types
+  - `settlCurrency` - Settlement currency for futures contracts
+  - `postOnly` - Post-only flag for maker-only LIMIT orders
+  - `pegOffsetType` - Peg offset type for PEG orders
+  - `offset` - Offset value for PEG orders (0 = peg to best bid/offer)
+  - `wigLevel` - WIG (Would if Good) level for pegged orders
+- **GetOrderPreviewRequest**: Added same advanced order fields as CreateOrderRequest plus:
+  - `displayQuoteSize` - Maximum order size visible on venue books (quote currency) for iceberg orders
+  - `displayBaseSize` - Maximum order size visible on venue books (base currency) for iceberg orders
+- **GetOrderPreviewResponse**: Added `isRaiseExact` field for raise exact order flag
+- **EditOrderRequest**: Added iceberg and stop order support
+  - `displayQuoteSize` - Display size for iceberg orders
+  - `displayBaseSize` - Display size for iceberg orders
+  - `stopPrice` - Stop price at which order activates
+
+#### Futures Service
+- **GetFcmRiskLimitsResponse**: Added comprehensive FCM margin and PnL fields
+  - `cfmTotalMargin` - Total margin required for both positions and open orders
+  - `cfmDeltaOte` - Open Trade Equity accrued during current trading session
+  - `cfmUnsettledRealizedPnl` - Unsettled realized PNL for positions closed intraday
+  - `cfmUnsettledAccruedFundingPnl` - Unsettled accrued funding PNL from last settlement
+
+#### Transactions Service
+- **CreateConversionResponse**: Added `transactionId` field - UUID of the conversion transaction
+
+#### Wallets Service
+- **CreateWalletResponse**: Added `networkFamily` field for wallet network family
+- **GetWalletDepositInstructionsResponse**: Added proper JSON property annotations
+  - `@JsonProperty("crypto_instructions")` for crypto deposit instructions
+  - `@JsonProperty("fiat_instructions")` for fiat deposit instructions
+
+### Changed
+
+#### Breaking Changes
+- **GetCrossMarginOverviewResponse** (Financing Service): Renamed field and methods for OpenAPI alignment
+  - Field: `crossMarginOverview` → `overview`
+  - JSON property: `"cross_margin_overview"` → `"overview"`
+  - Getter: `getCrossMarginOverview()` → `getOverview()`
+  - Setter: `setCrossMarginOverview()` → `setOverview()`
+
+### Fixed
+- Aligned all Request/Response classes with OpenAPI specification v0.1
+- Fixed missing optional fields across 11 classes in 5 services
+- Added 26 fields total to match OpenAPI spec completely
+- Fixed JSON property mappings for proper snake_case to camelCase conversion
+- Fixed acronym casing in model classes (XM* → Xm*, FCM* → Fcm*) to match Java naming conventions
+- Fixed field naming consistency across Request/Response classes
+- Corrected method signatures and naming:
+  - `getAllocationsByClientNettingId` → `listAllocationsByNettingId`
+  - Updated corresponding request/response classes: `GetAllocationsByClientNettingIdRequest` → `ListAllocationsByNettingIdRequest`
+- Fixed activity type enum: `PrimeActivityType` → `CustodyActivityType`
+- Removed `nettingId` field from `CreateAllocationRequest` to align with API specification
+
 ## [1.4.0] - 2025-10-15
 
 ### Added

pom.xml

@@ -21,7 +21,7 @@
   <description>Sample Java SDK for the Coinbase Prime REST APIs</description>
   <groupId>com.coinbase.prime</groupId>
   <url>https://github.com/coinbase-samples/prime-sdk-java</url>
-  <version>1.4.0</version>
+  <version>1.5.0</version>
   <licenses>
     <license>
       <name>Apache License, Version 2.0</name>

src/main/java/com/coinbase/prime/activities/ActivitiesServiceImpl.java

@@ -63,7 +63,7 @@ public ListEntityActivitiesResponse listEntityActivities(ListEntityActivitiesReq
     public GetPortfolioActivityResponse getPortfolioActivity(GetPortfolioActivityRequest request) throws CoinbasePrimeException {
         return this.request(
                 HttpMethod.GET,
-                request.getPath(),
+                String.format("/portfolios/%s/activities/%s", request.getPortfolioId(), request.getActivityId()),
                 null,
                 List.of(200),
                 new TypeReference<GetPortfolioActivityResponse>() {});

src/main/java/com/coinbase/prime/activities/GetPortfolioActivityRequest.java

@@ -17,12 +17,19 @@
 package com.coinbase.prime.activities;
 
 import com.coinbase.prime.common.PrimeListRequest;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonProperty;
 
 /**
  * Request for getting a portfolio activity by activity ID.
  */
 public class GetPortfolioActivityRequest extends PrimeListRequest {
+    @JsonProperty(required = true, value = "portfolio_id")
+    @JsonIgnore
     private String portfolioId;
+
+    @JsonProperty(required = true, value = "activity_id")
+    @JsonIgnore
     private String activityId;
 
     public GetPortfolioActivityRequest() {
@@ -71,4 +78,4 @@ public GetPortfolioActivityRequest build() {
             return new GetPortfolioActivityRequest(this);
         }
     }
-}
+}

src/main/java/com/coinbase/prime/activities/ListEntityActivitiesRequest.java

@@ -32,13 +32,19 @@ public class ListEntityActivitiesRequest extends PrimeListRequest {
     @JsonProperty(required = true, value = "entity_id")
     @JsonIgnore
     private String entityId;
+
     @JsonProperty("activity_level")
     private ActivityLevel activityLevel;
+
     private String[] symbols;
+
     private ActivityCategory[] categories;
+
     private ActivityStatus[] statuses;
+
     @JsonProperty("start_time")
     private String startTime;
+
     @JsonProperty("end_time")
     private String endTime;
 

src/main/java/com/coinbase/prime/addressbook/CreateAddressBookEntryRequest.java

@@ -26,10 +26,14 @@ public class CreateAddressBookEntryRequest {
     @JsonProperty(required = true, value = "portfolio_id")
     @JsonIgnore
     private String portfolioId;
+
     private String address;
+
     @JsonProperty("currency_symbol")
     private String currencySymbol;
+
     private String name;
+
     @JsonProperty("account_identifier")
     private String accountIdentifier;
 

src/main/java/com/coinbase/prime/addressbook/CreateAddressBookEntryResponse.java

@@ -16,25 +16,27 @@
 
 package com.coinbase.prime.addressbook;
 
-import com.coinbase.prime.model.enums.PrimeActivityType;
+import com.coinbase.prime.model.enums.CustodyActivityType;
 import com.fasterxml.jackson.annotation.JsonProperty;
 
 public class CreateAddressBookEntryResponse {
     @JsonProperty("activity_type")
-    private PrimeActivityType activityType;
+    private CustodyActivityType activityType;
+
     @JsonProperty("num_approvals_remaining")
     private Integer numApprovalsRemaining;
+
     @JsonProperty("activity_id")
     private String activityId;
 
     public CreateAddressBookEntryResponse() {
     }
 
-    public PrimeActivityType getActivityType() {
+    public CustodyActivityType getActivityType() {
         return activityType;
     }
 
-    public void setActivityType(PrimeActivityType activityType) {
+    public void setActivityType(CustodyActivityType activityType) {
         this.activityType = activityType;
     }
 

src/main/java/com/coinbase/prime/addressbook/ListAddressBookRequest.java

@@ -29,8 +29,10 @@ public class ListAddressBookRequest extends PrimeListRequest {
     @JsonProperty(required = true, value = "portfolio_id")
     @JsonIgnore
     private String portfolioId;
+
     @JsonProperty("currency_symbol")
     private String currencySymbol;
+
     private String search;
 
     public ListAddressBookRequest() {

src/main/java/com/coinbase/prime/addressbook/ListAddressBookResponse.java

@@ -21,6 +21,7 @@
 
 public class ListAddressBookResponse {
     private AddressBookEntry[] addresses;
+
     private Pagination pagination;
 
     public ListAddressBookResponse() {