Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moduleDeps should be runModuleDeps #3859

Closed
lefou opened this issue Oct 28, 2024 · 0 comments · Fixed by #3860
Closed

moduleDeps should be runModuleDeps #3859

lefou opened this issue Oct 28, 2024 · 0 comments · Fixed by #3860
Milestone

Comments

@lefou
Copy link
Member

lefou commented Oct 28, 2024

/** Should only be called from [[moduleDepsChecked]] */
private lazy val recRunModuleDeps: Seq[JavaModule] =
ModuleUtils.recursive[JavaModule](
(millModuleSegments ++ Seq(Segment.Label("moduleDeps"))).render,
this,
m => m.runModuleDeps ++ m.moduleDeps
)

Should this be: moduleDeps -> runModuleDeps ?

Originally posted by @myyk in #3774 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant