Tidy up code

Author: Matt Copas

theme/plugins/check-links/index.js

@@ -6,21 +6,23 @@ function getCacheKey(node) {
   return `check-links-${node.id}-${node.internal.contentDigest}`
 }
 
-function getPosition(string, subString, index) {
-  return string.split(subString, index).join(subString).length;
+function getNthPosition(string, subString, n) {
+  return string.split(subString, n).join(subString).length;
+}
+
+function convertToAbsolutePath(link, path) {
+  const moveUpDirectoryCount = (link.match(/\.\.\//g) || []).length
+  let pathWithoutTrailingSlash = path[path.length - 1] === '/' ? path.slice(0, path.length - 1) : path
+  const pathSlashCount = (path.match(/\//g) || []).length
+  const indexToSliceTo = getNthPosition(pathWithoutTrailingSlash, '/', pathSlashCount - moveUpDirectoryCount) + 1
+  const slicedPath = pathWithoutTrailingSlash.slice(0, indexToSliceTo)
+  const slicedLink = link.slice(moveUpDirectoryCount * 3, link.length)
+  return slicedPath.concat(slicedLink)
 }
 
 function convertToBasePath(link, path) {
   if (link.startsWith('../')) {
-    // Convert the relative link to an absolute one
-    const moveUpDirectoryCount = (link.match(/\.\.\//g) || []).length
-    let pathWithoutTrailingSlash = path[path.length - 1] === '/' ? path.slice(0, path.length - 1) : path
-    const pathSlashCount = (path.match(/\//g) || []).length
-    const indexToSliceTo = getPosition(pathWithoutTrailingSlash, '/', pathSlashCount - moveUpDirectoryCount) + 1
-    const slicedPath = pathWithoutTrailingSlash.slice(0, indexToSliceTo)
-    const slicedLink = link.slice(moveUpDirectoryCount * 3, link.length)
-    const concat = slicedPath.concat(slicedLink)
-    return concat.toLowerCase()
+    return convertToAbsolutePath(link, path).toLowerCase()
   }
   return link.toLowerCase().replace(/^\.\//, '') // strip ./