Skip to content

explicit node versions #9594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tremor021 merged 3 commits into from
Dec 3, 2025
Merged

explicit node versions #9594

tremor021 merged 3 commits into from
Dec 3, 2025

Conversation

@CrazyWolf13
Copy link
Member

@CrazyWolf13 CrazyWolf13 commented Dec 2, 2025

✍️ Description

Add Explicit node_version as default will increase to 24

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@CrazyWolf13 CrazyWolf13 requested a review from a team as a code owner December 2, 2025 13:42
@github-actions github-actions bot added refactor update script A change that updates a script labels Dec 2, 2025
@CrazyWolf13 CrazyWolf13 changed the title Update Node.js version to 22 in domain-locker script explicit node versions Dec 2, 2025
@tremor021 tremor021 merged commit 84057a6 into main Dec 3, 2025
2 checks passed
@tremor021 tremor021 deleted the CrazyWolf13-patch-3 branch December 3, 2025 23:06
jniles pushed a commit to jniles/ProxmoxVE that referenced this pull request Dec 5, 2025
@CrazyWolf13 @jniles
explicit node versions (community-scripts#9594)
514f7a1
probers1 pushed a commit to probers1/ProxmoxVE that referenced this pull request Dec 5, 2025
@CrazyWolf13 @probers1
explicit node versions (community-scripts#9594)
9ec96f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MickLesk MickLesk MickLesk approved these changes

@tremor021 tremor021 tremor021 approved these changes

Assignees

No one assigned

Labels

refactor update script A change that updates a script

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CrazyWolf13 @MickLesk @tremor021