Add explicit extern "C" #516
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 72.45% 72.45%
=======================================
Files 9 9
Lines 3591 3591
=======================================
Hits 2602 2602
Misses 989 989 🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
| @@ -12,7 +12,7 @@ | |||
| #include <stddef.h> | |||
| #include <stdint.h> | |||
|
|
|||
| LLVM_CLANG_C_EXTERN_C_BEGIN | |||
| extern "C" { | |||
There was a problem hiding this comment.
Can we include clang-c/ExternC.h which defines the macro instead?
There was a problem hiding this comment.
clang-c/ExternC.h is already included, it looks like this PR does not make sense.
|
maybe just merge #440? |
Good point. @adam-urbanczyk, can you still reproduce the issue with the master? |
Hi, I think the problem was relevant to the win use-case Those problems are resolved now once #440 went in (check #483 (comment)) |
|
Thank you! |
Description
I added explicit
extern "C"Fixes #515
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist