-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tried to modify key current
of an object which has been already passed to a worklet
#539
Comments
+1 react-native-draggable-flatlist: "4.0.1", both with Android and iOS. |
+1 |
+1 |
|
+1 |
+1 |
+1 |
1 similar comment
+1 |
+1 |
2 similar comments
+1 |
+1 |
Same thing, has anyone found a workaround? Maybe use another library? UPD: I removed the decorators and that warning still remains, but the behaviour is now correct. Perhaps later I will implement my own decorators and share them here |
Fixed with this patch. |
I can confirm its fixed with this patch Git diff: https://diffy.org/diff/a2b7ca0fa7657 |
The warning disappear
The warning disappeared when the component is initialised, but when I am dragging an element of the list, the warning reappears. I fixed it by changing this file (react-native-draggable-flatlist/src/hooks/useOnCellActiveAnimation.ts) on top of @ddrozdov's patch with this: |
Can we leave this open until the fix lands? |
yeah, It doesn't make sense to close an unsolved issue |
Well last update was a year ago so... |
@computerjazz are you still updating this lib or are you looking for maintainers to hand it over to? |
This is a good question! |
this work to me thx! |
Looks like issue reproduced with the newer versions of react-native / react-native-reanimated. Obviously, we cannot use patch, can maintainers publish a new package version with patch applied? |
Im have this issue too and had followed the installation guide, any solutions found? "react-native-draggable-flatlist": "^4.0.1", Edit: this patch did work |
I added one thing at react-native-draggable-flatlist+4.0.1.patch.txt my env
hope this helps. |
I'm also having this issue! |
With https://www.npmjs.com/package/patch-package you could, until #551 gets merged and released. |
For anyone looking for a temporary solution, I published the PR fork to npm to install like this: |
@bwjohns4 Could you open source it please? Your profile is fully closed 😕 |
It seems to be publicly available. I can access it from incognito browser and install it in Replit as a test. Let me know if there is something specific I'm missing. |
Describe the bug
I can see a warning realated to modify a prop from a ref i think, not shure were is it happening
Platform & Dependencies
Please list any applicable dependencies in addition to those below (react-navigation etc).
Additional context
https://docs.swmansion.com/react-native-reanimated/docs/guides/troubleshooting#tried-to-modify-key-of-an-object-which-has-been-converted-to-a-shareable
The text was updated successfully, but these errors were encountered: