Skip to content

Every governor role-gated call extends instance TTL twice #335

Description

@Jaydbrown

contracts/governor/src/lib.rs: require_role / require_role_or_admin (in role.rs) already call ttl::bump(env). Then grant_role, revoke_role, transfer_authority, propose_authority, governor_pause, governor_unpause, set_fee_bps, set_fee_recipient, set_min_duration, set_max_rate, set_max_duration each call ttl::bump(&env) again. Redundant extend_ttl work on every governance write. Bump once, in the auth helper.


Filed from a codebase review pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions