Skip to content

transfer_authority is marked Deprecated but is still a live one-step-to-a-dead-address footgun #337

Description

@Jaydbrown

contracts/governor/src/lib.rs transfer_authority doc: "Deprecated: Use propose_authority + accept_authority instead". It is still fully callable by any Admin, emits no deprecation event, and hands Admin to new_authority in a single call with no proof that address can sign — exactly the risk the 2-step flow was added to remove. Either remove it, or gate it behind an explicit "I understand" parameter and emit a distinct event.


Filed from a codebase review pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions