`propose_authority` accepts the zero address and silently overwrites a pending proposal

[Jaydbrown]

contracts/governor/src/lib.rs propose_authority does not call is_zero_stellar_account(&env, &new_authority) (unlike set_fee_recipient), does not check whether new_authority already holds Admin, and unconditionally overwrites DataKey::PendingAuthority / PendingAuthorityProposer. A fat-fingered proposal to the zero address, once accepted, would make the zero account the sole admin.

---

Filed from a codebase review pass.

[sherifatolanike]

@sherifatolanike has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi Maintainer, can I work on this issue please?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @sherifatolanike to this issue.

[Gimbiyar]

@Gimbiyar has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer, I’d be pleased to take on this issue. With experience across multiple backend frameworks, I’m confident in my ability to investigate the problem, identify the cause, and work toward a solution. Looking forward to contributing.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Gimbiyar to this issue.

[Toyosi5566]

@Toyosi5566 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Please assign this issue to me so I can immediately secure the propose_authority flow.

​Execution Plan:
​Strict Input Validation: Inject is_zero_stellar_account(&env, &new_authority) at the function entry in contracts/governor/src/lib.rs to revert zero-address assignments.

​State & Role Checks: Implement invariant checks to ensure new_authority does not currently hold the Admin role, and explicitly prevent silent overwrites of existing DataKey::PendingAuthority or PendingAuthorityProposer states.

​Test Verification: Write deterministic test coverage for the fat-finger scenarios (zero-address revert, active proposal overwrite attempt, redundant admin), incorporating references to 3f6968c4-e0e6-427c-a448-a9234f80558d.

​Assign this to me and I will open a PR with the fix and tests today.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Toyosi5566 to this issue.

[Omoboi-dev]

@Omoboi-dev has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer, I would like to work on this fix , please assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Omoboi-dev to this issue.

[drips-wave]

Congratulations, @Omoboi-dev! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Omoboi-dev: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @Omoboi-dev as part of the Stellar Wave Program's 8th Wave 🥳

😎 @Omoboi-dev: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.