Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments should also return a username field to show which user made the comment. #44

Open
mattrltrent opened this issue Apr 7, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattrltrent
Copy link
Member

Referring to the work done in branch comment_threads:

Currently, comments look like this upon being returned:

{
  "id": "SOME_MASKED_ID",
  "parent_comments": [
    "SOME_MASKED_ID",
    "SOME_MASKED_ID"
  ],
  "parent_post": "SOME_MASKED_ID",
  "text": "Hello, this is a comment.",
  "replies": 0,
  "children": [],
  "votes": {
    "up": 8,
    "down": 2
  }
},

They should be changed to include an additional field, username, that shows who created the comment. This is because comments are public while posts (confessions) are anonymous.

@mattrltrent mattrltrent added enhancement New feature or request good first issue Good for newcomers labels Apr 7, 2023
@hn275 hn275 linked a pull request Apr 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant