Skip to content

Commit 9134679

Browse files
authored
Merge pull request #3559 from simonbaird/testcontainers-archive-release-v0.9
chore(deps): Update testcontainers-go and moby/go-archive (v0.9)
2 parents 5b4814f + c526ea2 commit 9134679

10 files changed

Lines changed: 112 additions & 98 deletions

File tree

acceptance/git/git.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ func startStubGitServer(ctx context.Context) (context.Context, error) {
164164

165165
req := testenv.TestContainersRequest(ctx, testcontainers.ContainerRequest{
166166
Image: "docker.io/ynohat/git-http-backend",
167-
ExposedPorts: []string{"0.0.0.0::443/tcp"},
167+
ExposedPorts: []string{"443/tcp"},
168168
WaitingFor: wait.ForHTTP("/git/health-check.git/info/refs?service=git-upload-pack").
169169
WithPort("443/tcp").
170170
WithTLS(true).
@@ -196,7 +196,7 @@ func startStubGitServer(ctx context.Context) (context.Context, error) {
196196
return ctx, err
197197
}
198198

199-
state.HostAndPort = fmt.Sprintf("localhost:%d", port.Int())
199+
state.HostAndPort = fmt.Sprintf("localhost:%d", port.Num())
200200
state.RepositoriesDir = repositories
201201

202202
return ctx, nil

acceptance/go.mod

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ require (
1616
github.com/google/go-containerregistry v0.21.7
1717
github.com/in-toto/in-toto-golang v0.11.0
1818
github.com/konflux-ci/application-api v0.0.0-20240812090716-e7eb2ecfb409
19+
github.com/moby/moby/api v1.55.0
1920
github.com/opencontainers/image-spec v1.1.1
2021
github.com/otiai10/copy v1.14.0
2122
github.com/phayes/freeport v0.0.0-20220201140144-74d24b5ae9f5
@@ -29,7 +30,7 @@ require (
2930
github.com/stretchr/testify v1.12.1
3031
github.com/tektoncd/cli v0.44.1
3132
github.com/tektoncd/pipeline v1.12.0
32-
github.com/testcontainers/testcontainers-go v0.34.0
33+
github.com/testcontainers/testcontainers-go v0.44.0
3334
github.com/transparency-dev/merkle v0.0.2
3435
github.com/wiremock/go-wiremock v1.11.0
3536
github.com/yudai/gojsondiff v1.0.0
@@ -88,11 +89,11 @@ require (
8889
github.com/digitorus/timestamp v0.0.0-20231217203849-220c5c2851b7 // indirect
8990
github.com/distribution/reference v0.6.0 // indirect
9091
github.com/docker/cli v29.7.2+incompatible // indirect
91-
github.com/docker/docker v28.5.2+incompatible // indirect
9292
github.com/docker/docker-credential-helpers v0.9.8 // indirect
9393
github.com/docker/go-connections v0.7.0 // indirect
9494
github.com/docker/go-units v0.5.0 // indirect
9595
github.com/dustin/go-humanize v1.0.1 // indirect
96+
github.com/ebitengine/purego v0.10.1 // indirect
9697
github.com/emicklei/go-restful/v3 v3.13.0 // indirect
9798
github.com/emirpasic/gods v1.18.1 // indirect
9899
github.com/evanphx/json-patch v5.9.11+incompatible // indirect
@@ -159,23 +160,22 @@ require (
159160
github.com/kr/pretty v0.3.1 // indirect
160161
github.com/kr/text v0.2.0 // indirect
161162
github.com/letsencrypt/boulder v0.20260309.0 // indirect
162-
github.com/lufia/plan9stats v0.0.0-20240819163618-b1d8f4d146e7 // indirect
163+
github.com/lufia/plan9stats v0.0.0-20260330125221-c963978e514e // indirect
163164
github.com/magiconair/properties v1.8.10 // indirect
164165
github.com/maruel/natural v1.1.1 // indirect
165166
github.com/mattn/go-colorable v0.1.14 // indirect
166167
github.com/mattn/go-isatty v0.0.20 // indirect
167168
github.com/moby/docker-image-spec v1.3.1 // indirect
168-
github.com/moby/go-archive v0.2.0 // indirect
169+
github.com/moby/go-archive v0.3.1 // indirect
170+
github.com/moby/moby/client v0.5.0 // indirect
169171
github.com/moby/patternmatcher v0.6.1 // indirect
170-
github.com/moby/sys/atomicwriter v0.1.0 // indirect
171172
github.com/moby/sys/sequential v0.7.0 // indirect
172173
github.com/moby/sys/user v0.4.1 // indirect
173174
github.com/moby/sys/userns v0.2.0 // indirect
174175
github.com/moby/term v0.5.2 // indirect
175176
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
176177
github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect
177178
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect
178-
github.com/morikuni/aec v1.1.0 // indirect
179179
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
180180
github.com/nozzle/throttler v0.0.0-20180817012639-2ea982251481 // indirect
181181
github.com/oklog/ulid/v2 v2.1.1 // indirect
@@ -196,8 +196,7 @@ require (
196196
github.com/sassoftware/relic v7.2.1+incompatible // indirect
197197
github.com/sergi/go-diff v1.4.0 // indirect
198198
github.com/shibumi/go-pathspec v1.3.0 // indirect
199-
github.com/shirou/gopsutil/v3 v3.24.5 // indirect
200-
github.com/shoenig/go-m1cpu v0.1.6 // indirect
199+
github.com/shirou/gopsutil/v4 v4.26.6 // indirect
201200
github.com/sigstore/protobuf-specs v0.5.1 // indirect
202201
github.com/sigstore/rekor-tiles/v2 v2.3.0 // indirect
203202
github.com/sigstore/timestamp-authority/v2 v2.1.2 // indirect
@@ -213,8 +212,8 @@ require (
213212
github.com/tidwall/pretty v1.2.1 // indirect
214213
github.com/tidwall/sjson v1.2.5 // indirect
215214
github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399 // indirect
216-
github.com/tklauser/go-sysconf v0.3.14 // indirect
217-
github.com/tklauser/numcpus v0.8.0 // indirect
215+
github.com/tklauser/go-sysconf v0.4.0 // indirect
216+
github.com/tklauser/numcpus v0.12.0 // indirect
218217
github.com/transparency-dev/formats v0.1.1 // indirect
219218
github.com/x448/float16 v0.8.4 // indirect
220219
github.com/xanzy/ssh-agent v0.3.3 // indirect
@@ -272,8 +271,3 @@ require (
272271
sigs.k8s.io/randfill v1.0.0 // indirect
273272
sigs.k8s.io/structured-merge-diff/v6 v6.3.2 // indirect
274273
)
275-
276-
// Force moby/go-archive to v0.1.0 for compatibility with docker/docker v28.5.2
277-
// v0.2.0 removed archive.Compression type which docker still uses
278-
// (Maybe won't be needed in a future version of docker/docker.)
279-
replace github.com/moby/go-archive v0.2.0 => github.com/moby/go-archive v0.1.0

acceptance/go.sum

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,6 @@ github.com/distribution/reference v0.6.0 h1:0IXCQ5g4/QMHHkarYzh5l+u8T3t73zM5Qvfr
169169
github.com/distribution/reference v0.6.0/go.mod h1:BbU0aIcezP1/5jX/8MP0YiH4SdvB5Y4f/wlDRiLyi3E=
170170
github.com/docker/cli v29.7.2+incompatible h1:dlkwallR8XqfeVnA2ELEhdwvb4lsSwuB4IgsG8Q9cLY=
171171
github.com/docker/cli v29.7.2+incompatible/go.mod h1:JLrzqnKDaYBop7H2jaqPtU4hHvMKP+vjCwu2uszcLI8=
172-
github.com/docker/docker v28.5.2+incompatible h1:DBX0Y0zAjZbSrm1uzOkdr1onVghKaftjlSWt4AFexzM=
173-
github.com/docker/docker v28.5.2+incompatible/go.mod h1:eEKB0N0r5NX/I1kEveEz05bcu8tLC/8azJZsviup8Sk=
174172
github.com/docker/docker-credential-helpers v0.9.8 h1:bIREROb7So6PRlq6KTtdS9MPEjC29OQRkFNlvK2OX8Q=
175173
github.com/docker/docker-credential-helpers v0.9.8/go.mod h1:v1S+hepowrQXITkEfw6o4+BMbGot02wiKpzWhGUZK6c=
176174
github.com/docker/go-connections v0.7.0 h1:6SsRfJddP22WMrCkj19x9WKjEDTB+ahsdiGYf0mN39c=
@@ -181,6 +179,8 @@ github.com/doiit/picocolors v1.0.1 h1:cNzfymsOOjFeOY9Y/iCIs1ibTxBn6XTN2VsRc55uQG
181179
github.com/doiit/picocolors v1.0.1/go.mod h1:14SDQbQjAMLhoMbJkmaKxurWTPRPuy8R9qHJpx+B3y0=
182180
github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkpeCY=
183181
github.com/dustin/go-humanize v1.0.1/go.mod h1:Mu1zIs6XwVuF/gI1OepvI0qD18qycQx+mFykh5fBlto=
182+
github.com/ebitengine/purego v0.10.1 h1:dewVBCBT2GaMu1SrNTYxQhgQBethzfhiwvZiLGP/qyY=
183+
github.com/ebitengine/purego v0.10.1/go.mod h1:iIjxzd6CiRiOG0UyXP+V1+jWqUXVjPKLAI0mRfJZTmQ=
184184
github.com/elazarl/goproxy v1.7.2 h1:Y2o6urb7Eule09PjlhQRGNsqRfPmYI3KKQLFpCAV3+o=
185185
github.com/elazarl/goproxy v1.7.2/go.mod h1:82vkLNir0ALaW14Rc399OTTjyNREgmdL2cVoIbS6XaE=
186186
github.com/emicklei/go-restful/v3 v3.13.0 h1:C4Bl2xDndpU6nJ4bc1jXd+uTmYPVUwkD6bFY/oTyCes=
@@ -332,7 +332,6 @@ github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMyw
332332
github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
333333
github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
334334
github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
335-
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
336335
github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
337336
github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
338337
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
@@ -447,8 +446,8 @@ github.com/lib/pq v1.10.9 h1:YXG7RB+JIjhP29X+OtkiDnYaXQwpS4JEWq7dtCCRUEw=
447446
github.com/lib/pq v1.10.9/go.mod h1:AlVN5x4E4T544tWzH6hKfbfQvm3HdbOxrmggDNAPY9o=
448447
github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de h1:9TO3cAIGXtEhnIaL+V+BEER86oLrvS+kWobKpbJuye0=
449448
github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de/go.mod h1:zAbeS9B/r2mtpb6U+EI2rYA5OAXxsYw6wTamcNW+zcE=
450-
github.com/lufia/plan9stats v0.0.0-20240819163618-b1d8f4d146e7 h1:5RK988zAqB3/AN3opGfRpoQgAVqr6/A5+qRTi67VUZY=
451-
github.com/lufia/plan9stats v0.0.0-20240819163618-b1d8f4d146e7/go.mod h1:ilwx/Dta8jXAgpFYFvSWEMwxmbWXyiUHkd5FwyKhb5k=
449+
github.com/lufia/plan9stats v0.0.0-20260330125221-c963978e514e h1:Q6MvJtQK/iRcRtzAscm/zF23XxJlbECiGPyRicsX+Ak=
450+
github.com/lufia/plan9stats v0.0.0-20260330125221-c963978e514e/go.mod h1:autxFIvghDt3jPTLoqZ9OZ7s9qTGNAWmYCjVFWPX/zg=
452451
github.com/magiconair/properties v1.8.10 h1:s31yESBquKXCV9a/ScB3ESkOjUYYv+X0rg8SYxI99mE=
453452
github.com/magiconair/properties v1.8.10/go.mod h1:Dhd985XPs7jluiymwWYZ0G4Z61jb3vdS329zhj2hYo0=
454453
github.com/maruel/natural v1.1.1 h1:Hja7XhhmvEFhcByqDoHz9QZbkWey+COd9xWfCfn1ioo=
@@ -465,12 +464,14 @@ github.com/mitchellh/mapstructure v1.5.1-0.20231216201459-8508981c8b6c h1:cqn374
465464
github.com/mitchellh/mapstructure v1.5.1-0.20231216201459-8508981c8b6c/go.mod h1:bFUtVrKA4DC2yAKiSyO/QUcy7e+RRV2QTWOzhPopBRo=
466465
github.com/moby/docker-image-spec v1.3.1 h1:jMKff3w6PgbfSa69GfNg+zN/XLhfXJGnEx3Nl2EsFP0=
467466
github.com/moby/docker-image-spec v1.3.1/go.mod h1:eKmb5VW8vQEh/BAr2yvVNvuiJuY6UIocYsFu/DxxRpo=
468-
github.com/moby/go-archive v0.1.0 h1:Kk/5rdW/g+H8NHdJW2gsXyZ7UnzvJNOy6VKJqueWdcQ=
469-
github.com/moby/go-archive v0.1.0/go.mod h1:G9B+YoujNohJmrIYFBpSd54GTUB4lt9S+xVQvsJyFuo=
467+
github.com/moby/go-archive v0.3.1 h1:AHwfS8lTrPOb4rg9IFuc3k5Xg7jCzYidPt8SimWPHLM=
468+
github.com/moby/go-archive v0.3.1/go.mod h1:Npdv43fFqlhZW7Xo8fbm3ZMYFvAGNviUPqX21VERbcE=
469+
github.com/moby/moby/api v1.55.0 h1:2/sexvQyqIWS8pRSCFddBfpW2qE7vR7FCL+vN8pxwMc=
470+
github.com/moby/moby/api v1.55.0/go.mod h1:+RQ6wluLwtYaTd1WnPLykIDPekkuyD/ROWQClE83pzs=
471+
github.com/moby/moby/client v0.5.0 h1:5XhyPk2fuOWf6RlSFa3MkIIgDZkF25xToXW8Q/BH7cc=
472+
github.com/moby/moby/client v0.5.0/go.mod h1:rcVpF8ncl9vo5gaIBdol6CnbEtSj1uxMvEV/UrykF/s=
470473
github.com/moby/patternmatcher v0.6.1 h1:qlhtafmr6kgMIJjKJMDmMWq7WLkKIo23hsrpR3x084U=
471474
github.com/moby/patternmatcher v0.6.1/go.mod h1:hDPoyOpDY7OrrMDLaYoY3hf52gNCR/YOUYxkhApJIxc=
472-
github.com/moby/sys/atomicwriter v0.1.0 h1:kw5D/EqkBwsBFi0ss9v1VG3wIkVhzGvLklJ+w3A14Sw=
473-
github.com/moby/sys/atomicwriter v0.1.0/go.mod h1:Ul8oqv2ZMNHOceF643P6FKPXeCmYtlQMvpizfsSoaWs=
474475
github.com/moby/sys/sequential v0.7.0 h1:ASQNGNROJSuOO6LL6bPHbKvuZu6NU8P4ldPWk31zj/8=
475476
github.com/moby/sys/sequential v0.7.0/go.mod h1:NfSTAp6V3fw4tmkD62PEcOKeZKquXT8VKCkf7aVR79o=
476477
github.com/moby/sys/user v0.4.1 h1:RgjRlaDKi/Xmyrz4t8lyzXT6v2ooFeO/7xtchmhVWE0=
@@ -487,8 +488,6 @@ github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee h1:W5t00kpgFd
487488
github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk=
488489
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 h1:n6/2gBQ3RWajuToeY6ZtZTIKv2v7ThUy5KKusIT0yc0=
489490
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00/go.mod h1:Pm3mSP3c5uWn86xMLZ5Sa7JB9GsEZySvHYXCTK4E9q4=
490-
github.com/morikuni/aec v1.1.0 h1:vBBl0pUnvi/Je71dsRrhMBtreIqNMYErSAbEeb8jrXQ=
491-
github.com/morikuni/aec v1.1.0/go.mod h1:xDRgiq/iw5l+zkao76YTKzKttOp2cwPEne25HDkJnBw=
492491
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
493492
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
494493
github.com/natefinch/atomic v1.0.1 h1:ZPYKxkqQOx3KZ+RsbnP/YsgvxWQPGxjC0oBt2AhwV0A=
@@ -573,12 +572,8 @@ github.com/sergi/go-diff v1.4.0 h1:n/SP9D5ad1fORl+llWyN+D6qoUETXNZARKjyY2/KVCw=
573572
github.com/sergi/go-diff v1.4.0/go.mod h1:A0bzQcvG0E7Rwjx0REVgAGH58e96+X0MeOfepqsbeW4=
574573
github.com/shibumi/go-pathspec v1.3.0 h1:QUyMZhFo0Md5B8zV8x2tesohbb5kfbpTi9rBnKh5dkI=
575574
github.com/shibumi/go-pathspec v1.3.0/go.mod h1:Xutfslp817l2I1cZvgcfeMQJG5QnU2lh5tVaaMCl3jE=
576-
github.com/shirou/gopsutil/v3 v3.24.5 h1:i0t8kL+kQTvpAYToeuiVk3TgDeKOFioZO3Ztz/iZ9pI=
577-
github.com/shirou/gopsutil/v3 v3.24.5/go.mod h1:bsoOS1aStSs9ErQ1WWfxllSeS1K5D+U30r2NfcubMVk=
578-
github.com/shoenig/go-m1cpu v0.1.6 h1:nxdKQNcEB6vzgA2E2bvzKIYRuNj7XNJ4S/aRSwKzFtM=
579-
github.com/shoenig/go-m1cpu v0.1.6/go.mod h1:1JJMcUBvfNwpq05QDQVAnx3gUHr9IYF7GNg9SUEw2VQ=
580-
github.com/shoenig/test v0.6.4 h1:kVTaSd7WLz5WZ2IaoM0RSzRsUD+m8wRR+5qvntpn4LU=
581-
github.com/shoenig/test v0.6.4/go.mod h1:byHiCGXqrVaflBLAMq/srcZIHynQPQgeyvkvXnjqq0k=
575+
github.com/shirou/gopsutil/v4 v4.26.6 h1:Mzr/npDtQC/xpeEuQKHZt8Zo9CmPvhTj8nkR8w5TLDs=
576+
github.com/shirou/gopsutil/v4 v4.26.6/go.mod h1:LZ6ewCSkBqUpvSOf+LsTGnRinC6iaNUNMGBtDkJBaLQ=
582577
github.com/sigstore/cosign/v3 v3.0.4 h1:SuEn9z8V0eyjF0PWxuGgQ7QSPWReNexLJovkZ3wLaf8=
583578
github.com/sigstore/cosign/v3 v3.0.4/go.mod h1:DJY5LPzHiI6bWpG/Q/NQUTfeASjkN8TDAUx1Nnt3I0I=
584579
github.com/sigstore/protobuf-specs v0.5.1 h1:/5OPaNuolRJmQfeZLayJGFXMpsRJEdgC6ah1/+7Px7U=
@@ -638,8 +633,8 @@ github.com/tektoncd/pipeline v1.12.0 h1:/a2ENIZYLwvvApWU8KHL5CWCj/fNjiGU/aTUu3up
638633
github.com/tektoncd/pipeline v1.12.0/go.mod h1:FaS4+AjlUmMOqkzLtdjaY40iLGbCiLkal/BsJ102FLI=
639634
github.com/tektoncd/triggers v0.35.0 h1:9Z5Cqn7RZTgyspWgWYFHz6AtWUUhd/awJeaisjZdF98=
640635
github.com/tektoncd/triggers v0.35.0/go.mod h1:te1wPij1VJ/59wqpVKfwxZHRS/FOZSCMSbBTpKtLfz4=
641-
github.com/testcontainers/testcontainers-go v0.34.0 h1:5fbgF0vIN5u+nD3IWabQwRybuB4GY8G2HHgCkbMzMHo=
642-
github.com/testcontainers/testcontainers-go v0.34.0/go.mod h1:6P/kMkQe8yqPHfPWNulFGdFHTD8HB2vLq/231xY2iPQ=
636+
github.com/testcontainers/testcontainers-go v0.44.0 h1:/Fwh6HY1mIikhnm9e7HwoxGycx0lzRAE0f5VQpjFxzI=
637+
github.com/testcontainers/testcontainers-go v0.44.0/go.mod h1:IcnwQrYTO86xHXu5bvMaBH7ATlbS3Qn1M1QWW3c66rE=
643638
github.com/theupdateframework/go-tuf v0.7.0 h1:CqbQFrWo1ae3/I0UCblSbczevCCbS31Qvs5LdxRWqRI=
644639
github.com/theupdateframework/go-tuf v0.7.0/go.mod h1:uEB7WSY+7ZIugK6R1hiBMBjQftaFzn7ZCDJcp1tCUug=
645640
github.com/theupdateframework/go-tuf/v2 v2.4.2 h1:w7976/W8uTwlsegP5nRymlpjPgrwSh+AXUf85is6nJk=
@@ -664,10 +659,10 @@ github.com/tink-crypto/tink-go/v2 v2.6.0 h1:+KHNBHhWH33Vn+igZWcsgdEPUxKwBMEe0QC6
664659
github.com/tink-crypto/tink-go/v2 v2.6.0/go.mod h1:2WbBA6pfNsAfBwDCggboaHeB2X29wkU8XHtGwh2YIk8=
665660
github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399 h1:e/5i7d4oYZ+C1wj2THlRK+oAhjeS/TRQwMfkIuet3w0=
666661
github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399/go.mod h1:LdwHTNJT99C5fTAzDz0ud328OgXz+gierycbcIx2fRs=
667-
github.com/tklauser/go-sysconf v0.3.14 h1:g5vzr9iPFFz24v2KZXs/pvpvh8/V9Fw6vQK5ZZb78yU=
668-
github.com/tklauser/go-sysconf v0.3.14/go.mod h1:1ym4lWMLUOhuBOPGtRcJm7tEGX4SCYNEEEtghGG/8uY=
669-
github.com/tklauser/numcpus v0.8.0 h1:Mx4Wwe/FjZLeQsK/6kt2EOepwwSl7SmJrK5bV/dXYgY=
670-
github.com/tklauser/numcpus v0.8.0/go.mod h1:ZJZlAY+dmR4eut8epnzf0u/VwodKmryxR8txiloSqBE=
662+
github.com/tklauser/go-sysconf v0.4.0 h1:7H0uAN+7RkwWRaxhYXDLqa5V3LPrJeV8wmD9dRUgPQU=
663+
github.com/tklauser/go-sysconf v0.4.0/go.mod h1:8mTNWyog7H+MpKijp4VmKJAd2bbYQ2zuUwkYRbUArPI=
664+
github.com/tklauser/numcpus v0.12.0 h1:NR85qdvHA9pFse3x3weVZ0r0ST8R6l5RHbZrlRaqob4=
665+
github.com/tklauser/numcpus v0.12.0/go.mod h1:ABHeXzJnr/qqwguhClkZKT1/8VABcYrsyUiUGobwWJg=
671666
github.com/transparency-dev/formats v0.1.1 h1:4bVHJc+KdBgpA1OJD1yjI+g0i5Z1graCppTMH8lWKJI=
672667
github.com/transparency-dev/formats v0.1.1/go.mod h1:qtZ8goRuJ8FTBG9c9+Bj0rn2rUG7eG/AUTkr+Aw3jFw=
673668
github.com/transparency-dev/merkle v0.0.2 h1:Q9nBoQcZcgPamMkGn7ghV8XiTZ/kRxn1yCG81+twTK4=
@@ -912,6 +907,8 @@ knative.dev/serving v0.39.4 h1:9IlFE7GsORKhI92DIZbF88hplQYM73T1l4W50UxZwF8=
912907
knative.dev/serving v0.39.4/go.mod h1:bWylSgwnRZeL659qy7m3/TZioYk25TIfusPUEeR695A=
913908
oras.land/oras-go/v2 v2.6.2 h1:N04RXngAp1LJKTG6ifz3xHPipasEkWr+hFmInja5YKo=
914909
oras.land/oras-go/v2 v2.6.2/go.mod h1:PlTtg4JTDJkDe8yVHpM2wz7/YDc00GVas+i4jAW2TZ4=
910+
pgregory.net/rapid v1.2.0 h1:keKAYRcjm+e1F0oAuU5F5+YPAWcyxNNRK2wud503Gnk=
911+
pgregory.net/rapid v1.2.0/go.mod h1:PY5XlDGj0+V1FCq0o192FdRhpKHGTRIWBgqjDBTrq04=
915912
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.34.0 h1:hSfpvjjTQXQY2Fol2CS0QHMNs/WI1MOSGzCm1KhM5ec=
916913
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.34.0/go.mod h1:Ve9uj1L+deCXFrPOk1LpFXqTg7LCFzFso6PA48q/XZw=
917914
sigs.k8s.io/controller-runtime v0.19.0 h1:nWVM7aq+Il2ABxwiCizrVDSlmDcshi9llbaFbC0ji/Q=

acceptance/registry/registry.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ func startStubRegistry(ctx context.Context) (context.Context, error) {
9494

9595
req := testenv.TestContainersRequest(ctx, testcontainers.ContainerRequest{
9696
Image: registryImage,
97-
ExposedPorts: []string{"0.0.0.0::5000/tcp"},
97+
ExposedPorts: []string{"5000/tcp"},
9898
WaitingFor: wait.ForHTTP("/v2/").WithPort("5000/tcp"),
9999
Cmd: []string{"serve", "/config/config.json"},
100100
Files: []testcontainers.ContainerFile{
@@ -125,7 +125,7 @@ func startStubRegistry(ctx context.Context) (context.Context, error) {
125125
return ctx, err
126126
}
127127

128-
state.HostAndPort = fmt.Sprintf("localhost:%d", port.Int())
128+
state.HostAndPort = fmt.Sprintf("localhost:%d", port.Num())
129129

130130
return ctx, nil
131131
}

acceptance/testenv/testenv.go

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,15 @@ import (
2323
"encoding/json"
2424
"errors"
2525
"fmt"
26+
"net/netip"
2627
"os"
2728
"os/exec"
2829
"path"
2930
"runtime"
3031
"testing"
3132

33+
"github.com/moby/moby/api/types/container"
34+
"github.com/moby/moby/api/types/network"
3235
"github.com/testcontainers/testcontainers-go"
3336
)
3437

@@ -254,6 +257,35 @@ func TestContainersRequest(ctx context.Context, req testcontainers.ContainerRequ
254257
os.Setenv("TESTCONTAINERS_RYUK_DISABLED", "true")
255258
}
256259

260+
// Publish the exposed ports on the IPv4 (0.0.0.0) address only. This avoids
261+
// accidentally reaching an unintended container that happens to be listening
262+
// on the same port over IPv6 (Ref. https://issues.redhat.com/browse/HACBS-1354).
263+
// This used to be expressed with the "0.0.0.0::<port>/tcp" ExposedPorts syntax,
264+
// but testcontainers-go v0.44 no longer accepts a host-binding IP in ExposedPorts,
265+
// so it must be set via PortBindings in a HostConfigModifier instead. Supplying a
266+
// HostConfigModifier replaces testcontainers' default one, so re-apply the fields
267+
// it would otherwise copy from the request.
268+
exposedPorts := req.ExposedPorts
269+
req.HostConfigModifier = func(hc *container.HostConfig) {
270+
hc.AutoRemove = req.AutoRemove
271+
hc.CapAdd = req.CapAdd
272+
hc.CapDrop = req.CapDrop
273+
hc.Binds = req.Binds
274+
hc.ExtraHosts = req.ExtraHosts
275+
hc.NetworkMode = req.NetworkMode
276+
hc.Resources = req.Resources
277+
hc.Privileged = req.Privileged
278+
hc.ShmSize = req.ShmSize
279+
280+
hc.PortBindings = network.PortMap{}
281+
for _, spec := range exposedPorts {
282+
// HostPort is left empty so Docker/Podman allocates a random host port.
283+
hc.PortBindings[network.MustParsePort(spec)] = []network.PortBinding{
284+
{HostIP: netip.IPv4Unspecified()},
285+
}
286+
}
287+
}
288+
257289
return req
258290
}
259291

acceptance/wiremock/wiremock.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ func StartWiremock(ctx context.Context) (context.Context, error) {
207207

208208
req := testenv.TestContainersRequest(ctx, testcontainers.ContainerRequest{
209209
Image: wireMockImage,
210-
ExposedPorts: []string{"0.0.0.0::8080/tcp", "0.0.0.0::8443/tcp"},
210+
ExposedPorts: []string{"8080/tcp", "8443/tcp"},
211211
WaitingFor: wait.ForHTTP("/__admin/mappings").WithPort("8080/tcp"),
212212
Binds: []string{fmt.Sprintf("%s:/recordings:z", recordings)},
213213
Cmd: []string{
@@ -233,7 +233,7 @@ func StartWiremock(ctx context.Context) (context.Context, error) {
233233
return ctx, err
234234
}
235235

236-
url := fmt.Sprintf("http://localhost:%d", port.Int())
236+
url := fmt.Sprintf("http://localhost:%d", port.Num())
237237
state.URL = url
238238

239239
return ctx, nil

benchmark/internal/registry/registry.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
"path"
3232
"time"
3333

34-
"github.com/docker/docker/api/types/container"
34+
"github.com/moby/moby/api/types/container"
3535
"github.com/smarty/cproxy/v2"
3636
"github.com/testcontainers/testcontainers-go"
3737
"github.com/testcontainers/testcontainers-go/modules/registry"

benchmark/offliner/offliner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ import (
2323
"os"
2424
"path/filepath"
2525

26-
"github.com/docker/docker/api/types/container"
2726
"github.com/google/go-containerregistry/pkg/crane"
2827
"github.com/google/go-containerregistry/pkg/logs"
2928
"github.com/google/go-containerregistry/pkg/name"
3029
"github.com/google/go-containerregistry/pkg/v1/remote"
30+
"github.com/moby/moby/api/types/container"
3131
"github.com/testcontainers/testcontainers-go"
3232
"github.com/testcontainers/testcontainers-go/modules/registry"
3333
)

0 commit comments

Comments
 (0)