Skip to content

chore(deps): Update google.golang.org/grpc and ubi base image (main) - #3519

Open
simonbaird wants to merge 1 commit into
conforma:mainfrom
simonbaird:go-mod-upgrade-grpc-main
Open

chore(deps): Update google.golang.org/grpc and ubi base image (main)#3519
simonbaird wants to merge 1 commit into
conforma:mainfrom
simonbaird:go-mod-upgrade-grpc-main

Conversation

@simonbaird

Copy link
Copy Markdown
Member

Update google.golang.org/grpc module dependency.

Version changes:

  • acceptance/go.mod: v1.82.0v1.83.2
  • go.mod: v1.82.0v1.83.2
  • tools/go.mod: v1.82.0v1.83.2

Commit created like this:

  hack/go-mod-upgrade-helper google.golang.org/grpc
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: fd3ea829-ff71-48b1-8e6f-014b46e371e6

📥 Commits

Reviewing files that changed from the base of the PR and between f712ec1 and 1cc50a7.

⛔ Files ignored due to path filters (4)
  • acceptance/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • tools/go.sum is excluded by !**/*.sum
  • tools/kubectl/go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • acceptance/go.mod
  • go.mod
  • tools/go.mod
  • tools/kubectl/go.mod

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates indirect Go dependencies across four module manifests. It upgrades CEL, networking, security, telemetry, SPIFFE, and gRPC modules. It also removes an obsolete indirect golang.org/x/tools entry from the kubectl module.

Changes

Go dependency refresh

Layer / File(s) Summary
Root module dependency updates
go.mod
The root module upgrades CEL, networking, security, tooling, telemetry detector, SPIFFE, and gRPC dependencies.
Acceptance and tools dependency alignment
acceptance/go.mod, tools/go.mod
The acceptance and tools modules align CEL, OpenTelemetry, SPIFFE, golang.org/x, and gRPC dependency versions.
Kubectl module dependency cleanup
tools/kubectl/go.mod
The kubectl module upgrades several golang.org/x dependencies and removes the obsolete indirect golang.org/x/tools entry.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 1cc50

This PR updates the gRPC dependency and related module checksums; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: robnester-rh

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title correctly identifies the gRPC dependency update but also claims an ubi base image update that is not present in the changes. Remove the ubi base image reference, or include the corresponding base image change.
Description check ⚠️ Warning The description states the dependency change and lists the affected files, but it omits the required What, Why, and Tickets headings and provides no rationale or ticket reference. Use the repository template. Add What, Why, and Tickets sections, including the reason for the upgrade and a related ticket or an explicit indication that no ticket applies.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@qodo-for-conforma

Copy link
Copy Markdown

PR Summary by Qodo

Upgrade gRPC to v1.83.2 across Go modules

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Upgrade gRPC to v1.83.2 across root, acceptance, and tools modules.
• Refresh transitive Go dependencies and checksums for all affected module graphs.
• Align kubectl helper dependencies with the resolved shared Go ecosystem versions.
Diagram

graph TD
  H["Upgrade helper"] --> G["gRPC v1.83.2"] --> R["Go resolver"] --> M["Root module"]
  R --> A["Acceptance module"]
  R --> T["Tools module"]
  R --> K["Kubectl module"]
  M --> S["Checksums"]
  A --> S
  T --> S
  K --> S
Loading
High-Level Assessment

The current approach is appropriate: use the repository's module-upgrade helper, update gRPC consistently in every module that resolves it, and commit the resolver-selected transitive versions and checksums. Updating only the root module was considered but would leave acceptance and tooling graphs inconsistent.

Files changed (8) +114 / -115

Other (8) +114 / -115
go.modUpgrade acceptance-test gRPC dependency +8/-8

Upgrade acceptance-test gRPC dependency

• Raises gRPC from v1.82.0 to v1.83.2 in the acceptance module. Also records resolver-selected updates to CEL and golang.org/x transitive dependencies.

acceptance/go.mod

go.sumRefresh acceptance dependency checksums +18/-18

Refresh acceptance dependency checksums

• Replaces checksums for gRPC and the transitive dependency versions selected by the acceptance module.

acceptance/go.sum

go.modUpgrade root gRPC and transitive dependencies +12/-12

Upgrade root gRPC and transitive dependencies

• Raises gRPC to v1.83.2 and updates related networking, security, telemetry, SPIFFE, CEL, and Go tooling dependencies selected by module resolution.

go.mod

go.sumRefresh root module checksums +24/-24

Refresh root module checksums

• Updates integrity hashes for gRPC v1.83.2 and all newly resolved transitive dependency versions.

go.sum

go.modUpgrade tools module gRPC dependency +12/-12

Upgrade tools module gRPC dependency

• Raises gRPC to v1.83.2 in the tools module and aligns its transitive dependency graph, including Go libraries, telemetry detectors, SPIFFE, and CEL.

tools/go.mod

go.sumRefresh tools dependency checksums +24/-24

Refresh tools dependency checksums

• Replaces checksums for the upgraded gRPC release and resolver-selected transitive dependencies used by development tools.

tools/go.sum

go.modAlign kubectl transitive Go dependencies +4/-5

Align kubectl transitive Go dependencies

• Updates networking, system, terminal, text, and tooling dependencies to versions selected by the refreshed module graph. Removes the now-unneeded explicit indirect golang.org/x/tools requirement.

tools/kubectl/go.mod

go.sumRefresh kubectl dependency checksums +12/-12

Refresh kubectl dependency checksums

• Updates checksums for the kubectl helper module's aligned golang.org/x dependency versions.

tools/kubectl/go.sum

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 26, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:21 PM UTC · Completed 2:28 PM UTC

Commit: 87c4a29 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.29

@qodo-for-conforma

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Aug 26, 2026
@simonbaird simonbaird changed the title chore(deps): Update google.golang.org/grpc (main) chore(deps): Update google.golang.org/grpc and ubi base image (main) Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.46% <ø> (-0.01%) ⬇️
generative 12.27% <ø> (ø)
integration 23.59% <ø> (ø)
unit 72.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant