Allow PNC SLSA build type for PipelineRun attestations - #1826
Conversation
Remove PNC build type from default provenance allowlist
|
🤖 Finished Review · ✅ Success · Started 9:46 AM UTC · Completed 9:58 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.44 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdds a helper and test for recognizing SLSA v1 attestations that use the PNC workflow build type through ChangesPNC attestation support
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR adds a localized regression test for custom PNC build-type handling without changing the global allowlist. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Looks good to me |
What:
Add a regression test showing that the PNC SLSA v1 build type can be accepted for PipelineRun attestations when it is explicitly provided through
rule_data.The PNC build type is not added to Conforma's global/default provenance allowlist.
Why:
PNC produces SLSA v1 attestations with a PNC-specific
buildType. The goal is to verify that Conforma can accept this build type through customrule_data, without enabling it globally for all Conforma users.Testing:
make fmt-checkpasses.git diff --checkpasses.Related:
This follows the suggestion to use custom
rule_datato enable the PNC build type instead of modifying the default provenance allowlist.