From 8881e158a8070496d17673632125cbd95ef56568 Mon Sep 17 00:00:00 2001 From: fullsend-code <278716306+fullsend-ai-coder[bot]@users.noreply.github.com> Date: Thu, 13 Aug 2026 13:51:41 +0000 Subject: [PATCH] docs(#1808): add THREAT_MODEL.md to change checklist for trust-boundary mods Add a "Security Documentation Maintenance" section to AGENTS.md that instructs PR authors to check and update THREAT_MODEL.md when modifying trust-boundary code in policy/lib/tekton/. Lists the key THREAT_MODEL.md sections to verify: Section 3.3 (trusted task data flow), threat entries DP-2 and LE-4, the security-critical rule data keys table, and open questions referencing changed components. Placed adjacent to the existing "Review Checklist for New Policy Rules" section since both serve as pre-merge checklists. Closes #1808 --- AGENTS.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/AGENTS.md b/AGENTS.md index 394d0b896..2fba723e3 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -100,6 +100,18 @@ Rego is a declarative policy language (Datalog-inspired), not imperative code: - **Test coverage:** Every new rule needs tests in a corresponding `_test.rego` file. CI enforces 100% coverage. +## Security Documentation Maintenance + +When a PR modifies trust-boundary code — specifically files in `policy/lib/tekton/` +that handle trusted task rules, data input paths, or merge/validation logic — +check whether `THREAT_MODEL.md` describes the affected architecture. If it does, +update the relevant sections in the same PR. Key sections to check: + +- Section 3.3 (trusted task data flow and merge architecture) +- Threat entries DP-2 and LE-4 (injection and precedence threats) +- The security-critical rule data keys table +- Open questions and recommendations referencing the changed components + ## PR Conventions Conventional commits are encouraged. Run `make ci` before pushing. CI runs on every PR via