Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy.Options.EnsureCompressionVariantsExist doesn’t detect existing variants with zstd:chunked #2318

Open
mtrmac opened this issue Feb 28, 2024 · 0 comments
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Feb 28, 2024

Right now skopeo copy --add-compression=zstd:chunked doesn’t exist — but if it did, repeated copies would keep adding new zstd:chunked instances.

We detect whether the desired instance already exists by the io.github.containers.compression.zstd annotation, but that only means “zstd”; so the code never determines that a zstd:chunked instance exists.

We would either need to add a new annotation (annotation value? or a new key?), or to actually fetch the per-instance manifest to see whether all layers are chunked.

Cc: @giuseppe

@mtrmac mtrmac added the kind/bug A defect in an existing functionality (or a PR fixing it) label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Development

No branches or pull requests

1 participant