chore(sdk): test using utf8 chars#91
Merged
Merged
Conversation
dyro
force-pushed
the
dyross/CAI-9294
branch
4 times, most recently
from
31f44a3 to
5183480
Compare
dyro
force-pushed
the
dyross/CAI-9294
branch
3 times, most recently
from
646c500 to
626b181
Compare
dyro
force-pushed
the
dyross/CAI-9294
branch
18 times, most recently
from
59f5520 to
d89d9c5
Compare
dyro
force-pushed
the
dyross/CAI-9294
branch
from
d89d9c5 to
4f9f87e
Compare
dyro
force-pushed
the
dyross/CAI-9294
branch
2 times, most recently
from
71f63da to
16b1ef3
Compare
dyro
force-pushed
the
dyross/CAI-9294
branch
from
16b1ef3 to
e23060c
Compare
dyro
commented
Sep 2, 2025
| inline std::string path_to_string(const filesystem::path &source_path) | ||
| { | ||
| return reinterpret_cast<const char *>(source_path.u8string().c_str()); | ||
| return source_path.u8string(); |
Contributor
Author
There was a problem hiding this comment.
Just cleaning up a bit. This doesn't affect the results of the workflows.
tmathern
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client was having an issue passing in a path with UTF-8 chars. This PR demonstrates that our SDK supports paths with unicode chars and cleans up an internal function.