feat: select org profile on sign in #8859
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
RomneyDa
requested changes
Nov 24, 2025
Collaborator
RomneyDa
left a comment
RomneyDa
left a comment
There was a problem hiding this comment.
There are some issues with this approach if cascadeInit runs into errors. Let's try to handle the selection change within the cascade init as opposed to clearing state outside of it. Maybe pass an isLogin boolean to cascadeInit?
dosubot
bot
added
size:XS
RomneyDa
requested changes
Nov 26, 2025
core/config/ConfigHandler.ts
Outdated
| this.globalContext.get("lastSelectedOrgIdForWorkspace") ?? {}; | ||
| const currentSelection = selectedOrgs[workspaceId]; | ||
| // reset selected org to first available org on login, otherwise use saved selection | ||
| const currentSelection = isLogin ? null : selectedOrgs[workspaceId]; |
Collaborator
There was a problem hiding this comment.
@uinstinct this feels closer but it would still unnecessarily lose someone's org selection if they were logging in for the 2nd time.
I think you could change the line
if(currentSelection)
to if(currentSelection && !(login && currentSelection === "personal")
Or something that doesn't just cut out the current selection regardless of personal or not
dosubot
bot
added
size:S
RomneyDa
approved these changes
Nov 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Select organization profile on sign in. If organization profile is not available, select the personal profile.
resolves CON-4960
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
before.mp4
after.mp4
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Automatically select the organization profile on sign in. If no org profile exists, fall back to the personal profile. Resolves CON-4960.
Written for commit aa0f50f. Summary will update automatically on new commits.