Feature/config dependent options#207
Merged
Merged
Conversation
- Add Integrators.build_options contract to abstract_integrator.jl
- Make SciML struct parametric with cached options_point and options_trajectory
- Update dense, save_everystep, save_start metadata to use Union{Bool, Symbol} with :auto default
- Pre-compute config-specific options in builder using CTSolvers internal API
- Add 3-arg solve_problem signature (no backward compatibility)
- Update calling.jl to call build_options and pass resolved options
- Update all test files with new signatures and add config-dependent options tests
- Add docstrings for new methods
Options behavior:
- PointConfig → dense=false, save_everystep=false, save_start=false
- TrajectoryConfig → dense=true, save_everystep=true, save_start=true
- Explicit values override :auto
All 663 tests passing.
- Document _AUTO_OPTION_KEYS constant with :auto resolution explanation - Add comprehensive docstring to build_sciml_integrator following docstrings.md template - Explain :auto sentinel behavior for PointConfig vs TrajectoryConfig - Add Arguments, Returns, Notes, and See also sections with proper @ref cross-references
OT is used as a type parameter name in SciML struct (options_trajectory type parameter)
Member
Author
|
Use control-toolbox/CTSolvers.jl#131 before merging, when the new release is out! |
Replace internal API call with public Options.options_dict(opts) now available in CTSolvers v0.4.17, simplifying the code.
Update to use the new public API Strategies.options_dict(opts::StrategyOptions) added in CTSolvers v0.4.17 for direct conversion from StrategyOptions to Dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.