Skip to content

Commit 15633da

Browse files
abbaseyaclaude
andcommitted
fix(build): bump rollup-plugin-typescript2 to 0.37 for picomatch 2.3.2
The recursive lockfile refresh in the previous commit broke `yarn build`: rollup-plugin-typescript2 silently stopped transforming and resolving, so rollup fell back to parsing raw TypeScript as JavaScript. Symptoms differed per package - `Could not resolve "./src/..."` in enums, and `Expected ',', got ':'` in js-sdk - but both are the same plugin going inert. Bisected on a pristine clone with a single variable: `yarn up -R picomatch` on its own takes the build from passing to failing. picomatch 2.3.1 -> 2.3.2 is itself a required security bump (4 advisories), so pinning it back is not an option. rollup-plugin-typescript2 0.37.0 works with picomatch 2.3.2, so the fix is to move the plugin forward rather than hold the transitive back. Verified after the change: - `yarn build` at the repo root: 50 bundles, exit 0 - `yarn lint` in packages/js-sdk: clean - all 546 mocha tests across the 10 test packages: passing - advisories unchanged at 41 (0 critical, 11 high), down from 236 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent b31c14b commit 15633da

14 files changed

Lines changed: 99 additions & 99 deletions

File tree

packages/api/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"rollup": "^4.53.2",
6262
"rollup-plugin-generate-package-json": "^3.2.0",
6363
"rollup-plugin-modify": "^3.0.0",
64-
"rollup-plugin-typescript2": "^0.36.0",
64+
"rollup-plugin-typescript2": "^0.37.0",
6565
"ts-node": "^10.9.2",
6666
"tslint": "^6.1.3",
6767
"tslint-config-prettier": "^1.18.0",
@@ -71,10 +71,10 @@
7171
},
7272
"version": "3.0.0",
7373
"peerDependencies": {
74-
"@convertcom/js-sdk-enums": ">=2.3.0",
75-
"@convertcom/js-sdk-event": ">=2.1.3",
76-
"@convertcom/js-sdk-logger": ">=2.1.2",
77-
"@convertcom/js-sdk-types": ">=3.11.0",
78-
"@convertcom/js-sdk-utils": ">=2.2.3"
74+
"@convertcom/js-sdk-enums": ">=3.0.0",
75+
"@convertcom/js-sdk-event": ">=3.0.0",
76+
"@convertcom/js-sdk-logger": ">=3.0.0",
77+
"@convertcom/js-sdk-types": ">=4.0.0",
78+
"@convertcom/js-sdk-utils": ">=3.0.0"
7979
}
80-
}
80+
}

packages/bucketing/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"rollup": "^4.53.2",
6262
"rollup-plugin-generate-package-json": "^3.2.0",
6363
"rollup-plugin-modify": "^3.0.0",
64-
"rollup-plugin-typescript2": "^0.36.0",
64+
"rollup-plugin-typescript2": "^0.37.0",
6565
"ts-node": "^10.9.2",
6666
"tslint": "^6.1.3",
6767
"tslint-config-prettier": "^1.18.0",
@@ -71,9 +71,9 @@
7171
},
7272
"version": "4.0.0",
7373
"peerDependencies": {
74-
"@convertcom/js-sdk-enums": ">=2.3.0",
75-
"@convertcom/js-sdk-logger": ">=2.1.2",
76-
"@convertcom/js-sdk-types": ">=3.11.0",
77-
"@convertcom/js-sdk-utils": ">=2.2.3"
74+
"@convertcom/js-sdk-enums": ">=3.0.0",
75+
"@convertcom/js-sdk-logger": ">=3.0.0",
76+
"@convertcom/js-sdk-types": ">=4.0.0",
77+
"@convertcom/js-sdk-utils": ">=3.0.0"
7878
}
79-
}
79+
}

packages/cloudflare/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"rollup": "^4.53.2",
4242
"rollup-plugin-generate-package-json": "^3.2.0",
4343
"rollup-plugin-modify": "^3.0.0",
44-
"rollup-plugin-typescript2": "^0.36.0",
44+
"rollup-plugin-typescript2": "^0.37.0",
4545
"typescript": "^5.9.3",
4646
"typescript-eslint": "^8.46.4"
4747
},

packages/data/package.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"rollup": "^4.53.2",
6262
"rollup-plugin-generate-package-json": "^3.2.0",
6363
"rollup-plugin-modify": "^3.0.0",
64-
"rollup-plugin-typescript2": "^0.36.0",
64+
"rollup-plugin-typescript2": "^0.37.0",
6565
"ts-node": "^10.9.2",
6666
"tslint": "^6.1.3",
6767
"tslint-config-prettier": "^1.18.0",
@@ -71,13 +71,13 @@
7171
},
7272
"version": "4.0.0",
7373
"peerDependencies": {
74-
"@convertcom/js-sdk-api": ">=2.1.4",
75-
"@convertcom/js-sdk-bucketing": ">=3.1.2",
76-
"@convertcom/js-sdk-enums": ">=2.3.0",
77-
"@convertcom/js-sdk-event": ">=2.1.3",
78-
"@convertcom/js-sdk-logger": ">=2.1.2",
79-
"@convertcom/js-sdk-rules": ">=2.1.4",
80-
"@convertcom/js-sdk-types": ">=3.11.0",
81-
"@convertcom/js-sdk-utils": ">=2.2.3"
74+
"@convertcom/js-sdk-api": ">=3.0.0",
75+
"@convertcom/js-sdk-bucketing": ">=4.0.0",
76+
"@convertcom/js-sdk-enums": ">=3.0.0",
77+
"@convertcom/js-sdk-event": ">=3.0.0",
78+
"@convertcom/js-sdk-logger": ">=3.0.0",
79+
"@convertcom/js-sdk-rules": ">=3.0.0",
80+
"@convertcom/js-sdk-types": ">=4.0.0",
81+
"@convertcom/js-sdk-utils": ">=3.0.0"
8282
}
83-
}
83+
}

packages/enums/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"prettier": "^3.6.2",
4242
"rollup": "^4.53.2",
4343
"rollup-plugin-generate-package-json": "^3.2.0",
44-
"rollup-plugin-typescript2": "^0.36.0",
44+
"rollup-plugin-typescript2": "^0.37.0",
4545
"ts-node": "^10.9.2",
4646
"tslint": "^6.1.3",
4747
"tslint-config-prettier": "^1.18.0",

packages/event/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"rollup": "^4.53.2",
6262
"rollup-plugin-generate-package-json": "^3.2.0",
6363
"rollup-plugin-modify": "^3.0.0",
64-
"rollup-plugin-typescript2": "^0.36.0",
64+
"rollup-plugin-typescript2": "^0.37.0",
6565
"ts-node": "^10.9.2",
6666
"tslint": "^6.1.3",
6767
"tslint-config-prettier": "^1.18.0",
@@ -71,8 +71,8 @@
7171
},
7272
"version": "3.0.0",
7373
"peerDependencies": {
74-
"@convertcom/js-sdk-enums": ">=2.3.0",
75-
"@convertcom/js-sdk-logger": ">=2.1.2",
76-
"@convertcom/js-sdk-types": ">=3.11.0"
74+
"@convertcom/js-sdk-enums": ">=3.0.0",
75+
"@convertcom/js-sdk-logger": ">=3.0.0",
76+
"@convertcom/js-sdk-types": ">=4.0.0"
7777
}
78-
}
78+
}

packages/experience/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"rollup": "^4.53.2",
6262
"rollup-plugin-generate-package-json": "^3.2.0",
6363
"rollup-plugin-modify": "^3.0.0",
64-
"rollup-plugin-typescript2": "^0.36.0",
64+
"rollup-plugin-typescript2": "^0.37.0",
6565
"ts-node": "^10.9.2",
6666
"tslint": "^6.1.3",
6767
"tslint-config-prettier": "^1.18.0",
@@ -71,9 +71,9 @@
7171
},
7272
"version": "3.0.0",
7373
"peerDependencies": {
74-
"@convertcom/js-sdk-data": ">=3.3.3",
75-
"@convertcom/js-sdk-enums": ">=2.3.0",
76-
"@convertcom/js-sdk-logger": ">=2.1.2",
77-
"@convertcom/js-sdk-types": ">=3.11.0"
74+
"@convertcom/js-sdk-data": ">=4.0.0",
75+
"@convertcom/js-sdk-enums": ">=3.0.0",
76+
"@convertcom/js-sdk-logger": ">=3.0.0",
77+
"@convertcom/js-sdk-types": ">=4.0.0"
7878
}
79-
}
79+
}

packages/js-sdk/package.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"rollup-plugin-generate-package-json": "^3.2.0",
7676
"rollup-plugin-jsdoc": "^0.1.2",
7777
"rollup-plugin-modify": "^3.0.0",
78-
"rollup-plugin-typescript2": "^0.36.0",
78+
"rollup-plugin-typescript2": "^0.37.0",
7979
"serve": "^14.2.5",
8080
"ts-node": "^10.9.2",
8181
"tslint": "^6.1.3",
@@ -87,16 +87,16 @@
8787
},
8888
"version": "5.0.0",
8989
"peerDependencies": {
90-
"@convertcom/js-sdk-api": ">=2.1.4",
91-
"@convertcom/js-sdk-bucketing": ">=3.1.2",
92-
"@convertcom/js-sdk-data": ">=3.3.3",
93-
"@convertcom/js-sdk-enums": ">=2.3.0",
94-
"@convertcom/js-sdk-event": ">=2.1.3",
95-
"@convertcom/js-sdk-experience": ">=2.3.2",
96-
"@convertcom/js-sdk-logger": ">=2.1.2",
97-
"@convertcom/js-sdk-rules": ">=2.1.4",
98-
"@convertcom/js-sdk-segments": ">=2.1.2",
99-
"@convertcom/js-sdk-types": ">=3.11.0",
100-
"@convertcom/js-sdk-utils": ">=2.2.3"
90+
"@convertcom/js-sdk-api": ">=3.0.0",
91+
"@convertcom/js-sdk-bucketing": ">=4.0.0",
92+
"@convertcom/js-sdk-data": ">=4.0.0",
93+
"@convertcom/js-sdk-enums": ">=3.0.0",
94+
"@convertcom/js-sdk-event": ">=3.0.0",
95+
"@convertcom/js-sdk-experience": ">=3.0.0",
96+
"@convertcom/js-sdk-logger": ">=3.0.0",
97+
"@convertcom/js-sdk-rules": ">=3.0.0",
98+
"@convertcom/js-sdk-segments": ">=3.0.0",
99+
"@convertcom/js-sdk-types": ">=4.0.0",
100+
"@convertcom/js-sdk-utils": ">=3.0.0"
101101
}
102-
}
102+
}

packages/logger/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"prettier": "^3.6.2",
5959
"rollup": "^4.53.2",
6060
"rollup-plugin-generate-package-json": "^3.2.0",
61-
"rollup-plugin-typescript2": "^0.36.0",
61+
"rollup-plugin-typescript2": "^0.37.0",
6262
"ts-node": "^10.9.2",
6363
"tslint": "^6.1.3",
6464
"tslint-config-prettier": "^1.18.0",
@@ -68,6 +68,6 @@
6868
},
6969
"version": "3.0.0",
7070
"peerDependencies": {
71-
"@convertcom/js-sdk-enums": ">=2.3.0"
71+
"@convertcom/js-sdk-enums": ">=3.0.0"
7272
}
73-
}
73+
}

packages/rules/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"rollup": "^4.53.2",
6262
"rollup-plugin-generate-package-json": "^3.2.0",
6363
"rollup-plugin-modify": "^3.0.0",
64-
"rollup-plugin-typescript2": "^0.36.0",
64+
"rollup-plugin-typescript2": "^0.37.0",
6565
"ts-node": "^10.9.2",
6666
"tslint": "^6.1.3",
6767
"tslint-config-prettier": "^1.18.0",
@@ -71,9 +71,9 @@
7171
},
7272
"version": "3.0.0",
7373
"peerDependencies": {
74-
"@convertcom/js-sdk-enums": ">=2.3.0",
75-
"@convertcom/js-sdk-logger": ">=2.1.2",
76-
"@convertcom/js-sdk-types": ">=3.11.0",
77-
"@convertcom/js-sdk-utils": ">=2.2.3"
74+
"@convertcom/js-sdk-enums": ">=3.0.0",
75+
"@convertcom/js-sdk-logger": ">=3.0.0",
76+
"@convertcom/js-sdk-types": ">=4.0.0",
77+
"@convertcom/js-sdk-utils": ">=3.0.0"
7878
}
79-
}
79+
}

0 commit comments

Comments
 (0)