Skip to content

Commit 5ba77c1

Browse files
authored
Merge pull request #318 from convertcom/feat/goal-custom-dimensions
feat/goal-custom-dimensions
2 parents 80124a4 + db55386 commit 5ba77c1

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
node_modules
22
CHANGELOG.md
3+
packages/types/src/config

packages/enums/src/goal-data-key.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,10 @@
77
export enum GoalDataKey {
88
AMOUNT = 'amount',
99
PRODUCTS_COUNT = 'productsCount',
10-
TRANSACTION_ID = 'transactionId'
10+
TRANSACTION_ID = 'transactionId',
11+
CUSTOM_DIMENSION_1 = 'customDimension1',
12+
CUSTOM_DIMENSION_2 = 'customDimension2',
13+
CUSTOM_DIMENSION_3 = 'customDimension3',
14+
CUSTOM_DIMENSION_4 = 'customDimension4',
15+
CUSTOM_DIMENSION_5 = 'customDimension5'
1116
}

packages/types/src/config/types.gen.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2529,11 +2529,11 @@ export type ConversionEvent = {
25292529
/**
25302530
* Key of the metric
25312531
*/
2532-
key?: 'amount' | 'productsCount' | 'transactionId';
2532+
key?: 'amount' | 'productsCount' | 'transactionId' | 'customDimension1' | 'customDimension2' | 'customDimension3' | 'customDimension4' | 'customDimension5';
25332533
/**
25342534
* Value of the metric
25352535
*/
2536-
value?: (number | string);
2536+
value?: (number | string | Array<string>);
25372537
}>;
25382538
/**
25392539
* Bucketing data (experiences that this visitor is currently part of) for the visitor. In case that **enrichData=true** flag is being sent and
@@ -2830,4 +2830,4 @@ export type $OpenApiTs = {
28302830
};
28312831
};
28322832
};
2833-
};
2833+
};

0 commit comments

Comments
 (0)