fix(rules): properly short-circuit AND logic to return RuleError instead of false

Author: abbaseya

package.json

@@ -53,7 +53,8 @@
   "devDependencies": {
     "@types/eslint-plugin-mocha": "^10",
     "eslint-plugin-mocha": "^11.2.0",
-    "eslint-plugin-prettier": "^5.5.4"
+    "eslint-plugin-prettier": "^5.5.4",
+    "prettier": "^3.6.2"
   },
   "resolutions": {
     "form-data": ">=4.0.4",

packages/rules/src/rule-manager.ts

@@ -195,17 +195,16 @@ export class RuleManager implements RuleManagerInterface {
     ) {
       for (let i = 0, l = rulesSubset.AND.length; i < l; i++) {
         match = this._processORWHEN(data, rulesSubset.AND[i]);
-        if (match === false) {
-          return false;
+        // AND requires ALL to explicitly return true
+        if (match !== true) {
+          return match;
         }
       }
-      if (match !== false) {
-        this._loggerManager?.info?.(
-          'RuleManager._processAND()',
-          MESSAGES.RULE_MATCH_AND
-        );
-      }
-      return match;
+      this._loggerManager?.info?.(
+        'RuleManager._processAND()',
+        MESSAGES.RULE_MATCH_AND
+      );
+      return true;
     } else {
       this._loggerManager?.warn?.(
         'RuleManager._processAND()',

yarn.lock

@@ -26013,6 +26013,7 @@ __metadata:
     "@types/eslint-plugin-mocha": "npm:^10"
     eslint-plugin-mocha: "npm:^11.2.0"
     eslint-plugin-prettier: "npm:^5.5.4"
+    prettier: "npm:^3.6.2"
   languageName: unknown
   linkType: soft