Skip to content

Feature: onboarding second phase #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
franpb14 opened this issue May 7, 2021 · 3 comments · May be fixed by #637
Closed

Feature: onboarding second phase #636

franpb14 opened this issue May 7, 2021 · 3 comments · May be fixed by #637
Assignees
@franpb14
Labels
feature

Comments

@franpb14
Copy link
Collaborator

franpb14 commented May 7, 2021 •
edited
Loading

For this second phase I will implement a map with the time banks in timeoverflow and also make a mention to the ones that are not there but can be found on bdtonline.
I have some doubts,

  • Should I put it under the table of organisations?
  • And what technology should I use? I have made a small study on some of them:

  1. Here: I have used it previously and it has given me very good results (easy to implement and highly editable).

  2. Mapbox: I have seen some gems that could be tested, mapbox-gl-rails and perhaps mapbox-rails

  3. OpenLayers: is the same as the one used by bdtonline but looking at the documentation it seems that you have to use cdn or nodeJS. I have also seen this gem but it has not been updated since 2014.

  4. Leaflet: It has its downloadable and usable code, it also has this gem that looks good.

I don't know much about the demand for the site and whether the free plans can easily be used up so I don't know if one of the first two can be used.

If you know of any other technology that might be more useful, we can obviously use that one.
@franpb14 franpb14 self-assigned this May 7, 2021
@franpb14
Copy link
Collaborator Author

franpb14 commented May 10, 2021 •
edited
Loading

I have been testing Leaflet, because I think that it is the best option, given that it is not paid and that it uses an open source map. I'm happy with the results, the code with the gem leaflet-rails can be very simple and concise. Using the downloaded version and JavaScript works fine too.
Screenshot from 2021-05-10 13-13-26

@sseerrggii
Copy link
Contributor

sseerrggii commented May 12, 2021 •
edited
Loading

For me it's ok

What do you think @markets ?

@markets
Copy link
Collaborator

markets commented May 12, 2021

Leaflet is open source solution, so +1 from my side!

franpb14 added a commit that referenced this issue May 12, 2021
@franpb14
feat: the map is working with the leaflet-rails gem
96dcebd 
I have also added two attributes (latitude and longitude) for the organisation and therefore changed forms for active-admin and update. I have also created a personalised marker. Issue #636.
franpb14 added a commit that referenced this issue May 12, 2021
@franpb14
tests: the map markers and the update have been tested
372d496 
The validator has been tested and has also been tested with valid parameters. The assignment of markers has been tested as well. Issue #636
@franpb14 franpb14 mentioned this issue May 12, 2021
Open
@sseerrggii sseerrggii closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franpb14 franpb14

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

The map is working coopdevs/timeoverflow
3 participants
@markets @sseerrggii @franpb14