[DRAFT]front: open tab next to current tab #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is hacky, but allows to have the same behaviour than that of gtk / proteus Fix PCLAS-713
Fix PCLAS-597 Co-authored-by: Jean Cavallo <[email protected]>
…W] (coopengo#187) For performance reasons it's better not to mix DOM reading and modifying especially in JS loops. PCLAS-772
…REVIEW] (coopengo#50) Co-authored-by: Jean Cavallo <[email protected]>
…age [CUSTOM] (coopengo#188) Fix #PJAZZ-2008
* Optimize instance creation in __getattr__ [PREVIEW] Accessing a M2O field from a X2M field could result in as many instantiations as there are records in the X2M field. It could be a performance bottleneck due to the many creations of Model kwargs and potential useless calls of transaction.set_context(). Thus the optimization is twofold: - Create an additional code path when the M2O field modifies the context - Cache the kwargs creation process to prevent extra calls resulting in the same dictionary * Use read to fetch reverse field value of O2M field in get [PREVIEW] Using a browse there in order to get the id is a performance bottleneck as it will result in the instanciation of potentially thousands of models. --------- Co-authored-by: Jean Cavallo <[email protected]>
Closes PCLAS-818 --------- Co-authored-by: Jean Cavallo <[email protected]>
Unfix PCLAS-838
…ource (coopengo#214)" This reverts commit 4667eea.
…pengo#219) * Optimize instance creation in ModelStorage.__getattr__ [PREVIEW] https://bugs.tryton.org/13245 * Sort X2M fields according to the order [PREVIEW] Fix PCLAS-889 https://bugs.tryton.org/13288
…REVIEW] (coopengo#372) Fix PCLAS-1280 https://bugs.tryton.org/13763 --------- Co-authored-by: Jean Cavallo <[email protected]>
Fix #PROCK-3484
This one is a complicated beast:
- having defined an `overflow-x: auto` in CSS on modal-body make it
a new Block Formatting Context
- Block Formatting Context contains their floating elements
- This is why although the ul menu is in the same stacking context
than the modal footer, the menu does not appear above it.
- Thus setting the `overflow` property will also reset the
`overflow-x` property and since the value is `visible` it does not
create a new Block Formatting Context, ensuring the `z-index` take
effect.
Fix PCLAS-1506
* Unconditionally enable button after a clic [CUSTOM] PCLAS-1522 * Only call the button state setting when the call to button failed * Remove console.log
…ion [PREVIEW] (coopengo#390) https://bugs.tryton.org/13869 Fix PCLAS-1521 Co-authored-by: Jean Cavallo <[email protected]>
Fix #PMETA-2420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PCLAS-1531