Skip to content

Commit b9dbc5c

Browse files
committed
cmd-build-with-buildah: clean up overrides repo metadata
If there are no rpms then let's clean up the repo metadata if it exists which should prevent cosmetic warts like: ``` Updating and loading repositories: overrides ???% | 0.0 B/s | -1.0 B | ? >>> Curl error (37): Could not read a file:// file for file:///run/src/overrides >>> Usable URL not found ``` Or fatal ones like: ``` error: Installing packages: importing RPMs: failed to open /run/src/overrides/rpm/systemd-258~rc3-2.fc44.x86_64.rpm ```
1 parent 57e8499 commit b9dbc5c

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/cmd-build-with-buildah

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,13 @@ build_with_buildah() {
161161
fi
162162

163163
if [ -d overrides ]; then
164-
if [[ -n $(ls overrides/rpm/*.rpm 2> /dev/null) ]]; then
165-
(cd overrides/rpm && rm -rf .repodata && createrepo_c .)
164+
if [ -d overrides/rpm ]; then
165+
# Clean up any previous repo metadata
166+
rm -rf overrides/rpm/repodata
167+
if [[ -n $(ls overrides/rpm/*.rpm 2> /dev/null) ]]; then
168+
# Generate new repo metadata since there are RPMs
169+
(cd overrides/rpm && createrepo_c .)
170+
fi
166171
fi
167172
set -- "$@" -v "$(realpath overrides)":/run/src/overrides
168173
fi

0 commit comments

Comments
 (0)