Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] store theme resolved could cache the resolved store theme #1803

Open
dkarlovi opened this issue Nov 29, 2021 · 1 comment
Open

[Perf] store theme resolved could cache the resolved store theme #1803

dkarlovi opened this issue Nov 29, 2021 · 1 comment
Assignees
@dpfaffenbauer
Labels
enhancement

Comments

@dkarlovi
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

In CS 2.2.x, the method CoreShop\Bundle\StoreBundle\Theme\StoreThemeResolver::resolveTheme will always do database queries to establish the theme, even though the resolved theme could be cached.
@dkarlovi dkarlovi mentioned this issue Nov 29, 2021
Open
@dpfaffenbauer
Copy link
Member

Cached with Pimcore Cache?

@dpfaffenbauer dpfaffenbauer mentioned this issue Aug 27, 2024
Open
@dpfaffenbauer dpfaffenbauer self-assigned this Aug 27, 2024
@dpfaffenbauer dpfaffenbauer added this to the 3.2.13 milestone Aug 27, 2024
@dpfaffenbauer dpfaffenbauer removed this from the 3.2.13 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpfaffenbauer dpfaffenbauer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkarlovi @dpfaffenbauer