Skip to content

Conversation

@martindstone
Copy link
Contributor

Background

Confluence pages containing links need to have their links modified so that they open in a new tab

This PR

modifies links found in the retrieved HTML so that they open in a new tab

Checklists

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

plugins/confluence-plugin/src/components/PageContent.tsx:197

  • Directly mutating the 'contents' object may lead to unexpected rendering issues. Consider updating the state using a setter to ensure proper re-rendering.
contents[`${entityPage.id}`].body = fixHtml(contents[`${entityPage.id}`].body, baseConfluenceUrl);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants